Fix bug introduced in 4.2.0 #391
Merged
+9
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshmgross
reviewed
Mar 19, 2025
Contributor
joshmgross
left a comment
joshmgross
left a comment
There was a problem hiding this comment.
Can we include tests to avoid future regressions?
And can you link to the issue this is fixing?
joshmgross
approved these changes
Mar 19, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output statements used to print download summary info & set download path output were erroneously moved to inside a loop, this change moves them back outside the loop, to ensure they are executed the correct amount of times in every case.
Closes this issue