-
Notifications
You must be signed in to change notification settings - Fork 667
Update GHES guidance to include reference to Node 20 version #440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the documentation to inform GHES users about the availability of a Node 20 version of the download-artifact action. Since Node 16 is deprecated, this change helps users understand they can upgrade to v3-node20 instead of being limited to the deprecated v3 version.
Key changes:
- Updated GHES guidance to mention both v3 (Node 16) and v3-node20 (Node 20) options
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Snapp949
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
… ci] Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 6.0.0 to 7.0.0. Release notes *Sourced from [actions/download-artifact's releases](https://github.com/actions/download-artifact/releases).* > v7.0.0 > ------ > > v7 - What's new > --------------- > > > [!IMPORTANT] > > actions/download-artifact@v7 now runs on Node.js 24 (`runs.using: node24`) and requires a minimum Actions Runner version of 2.327.1. If you are using self-hosted runners, ensure they are updated before upgrading. > > ### Node.js 24 > > This release updates the runtime to Node.js 24. v6 had preliminary support for Node 24, however this action was by default still running on Node.js 20. Now this action by default will run on Node.js 24. > > What's Changed > -------------- > > * Update GHES guidance to include reference to Node 20 version by [`@patrikpolyak`](https://github.com/patrikpolyak) in [actions/download-artifact#440](https://github.com/actions/download-artifact/pull/440) > * Download Artifact Node24 support by [`@salmanmkc`](https://github.com/salmanmkc) in [actions/download-artifact#415](https://github.com/actions/download-artifact/pull/415) > * fix: update `@actions/artifact` to fix Node.js 24 punycode deprecation by [`@salmanmkc`](https://github.com/salmanmkc) in [actions/download-artifact#451](https://github.com/actions/download-artifact/pull/451) > * prepare release v7.0.0 for Node.js 24 support by [`@salmanmkc`](https://github.com/salmanmkc) in [actions/download-artifact#452](https://github.com/actions/download-artifact/pull/452) > > New Contributors > ---------------- > > * [`@patrikpolyak`](https://github.com/patrikpolyak) made their first contribution in [actions/download-artifact#440](https://github.com/actions/download-artifact/pull/440) > * [`@salmanmkc`](https://github.com/salmanmkc) made their first contribution in [actions/download-artifact#415](https://github.com/actions/download-artifact/pull/415) > > **Full Changelog**: <actions/download-artifact@v6.0.0...v7.0.0> Commits * [`37930b1`](actions/download-artifact@37930b1) Merge pull request [#452](https://github.com/actions/download-artifact/issues/452) from actions/download-artifact-v7-release * [`72582b9`](actions/download-artifact@72582b9) doc: update readme * [`0d2ec9d`](actions/download-artifact@0d2ec9d) chore: release v7.0.0 for Node.js 24 support * [`fd7ae8f`](actions/download-artifact@fd7ae8f) Merge pull request [#451](https://github.com/actions/download-artifact/issues/451) from actions/fix-storage-blob * [`d484700`](actions/download-artifact@d484700) chore: restore minimatch.dep.yml license file * [`03a8080`](actions/download-artifact@03a8080) chore: remove obsolete dependency license files * [`56fe6d9`](actions/download-artifact@56fe6d9) chore: update `@actions/artifact` license file to 5.0.1 * [`8e3ebc4`](actions/download-artifact@8e3ebc4) chore: update package-lock.json with `@actions/artifact`[`@5`](https://github.com/5).0.1 * [`1e3c4b4`](actions/download-artifact@1e3c4b4) fix: update `@actions/artifact` to ^5.0.0 for Node.js 24 punycode fix * [`458627d`](actions/download-artifact@458627d) chore: use local `@actions/artifact` package for Node.js 24 testing * Additional commits viewable in [compare view](actions/download-artifact@018cc2c...37930b1) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Bumps actions/download-artifact from 6.0.0 to 7.0.0. ## Release notes Sourced from actions/download-artifact's releases. v7.0.0 v7 - What's new [!IMPORTANT] actions/download-artifact@v7 now runs on Node.js 24 (runs.using: node24) and requires a minimum Actions Runner version of 2.327.1. If you are using self-hosted runners, ensure they are updated before upgrading. Node.js 24 This release updates the runtime to Node.js 24. v6 had preliminary support for Node 24, however this action was by default still running on Node.js 20. Now this action by default will run on Node.js 24. What's Changed Update GHES guidance to include reference to Node 20 version by @patrikpolyak in actions/download-artifact#440 Download Artifact Node24 support by @salmanmkc in actions/download-artifact#415 fix: update @actions/artifact to fix Node.js 24 punycode deprecation by @salmanmkc in actions/download-artifact#451 prepare release v7.0.0 for Node.js 24 support by @salmanmkc in actions/download-artifact#452 New Contributors @patrikpolyak made their first contribution in actions/download-artifact#440 @salmanmkc made their first contribution in actions/download-artifact#415 Full Changelog: actions/download-artifact@v6.0.0...v7.0.0 ## Commits 37930b1 Merge pull request #452 from actions/download-artifact-v7-release 72582b9 doc: update readme 0d2ec9d chore: release v7.0.0 for Node.js 24 support fd7ae8f Merge pull request #451 from actions/fix-storage-blob d484700 chore: restore minimatch.dep.yml license file 03a8080 chore: remove obsolete dependency license files 56fe6d9 chore: update @actions/artifact license file to 5.0.1 8e3ebc4 chore: update package-lock.json with @actions/artifact@5.0.1 1e3c4b4 fix: update @actions/artifact to ^5.0.0 for Node.js 24 punycode fix 458627d chore: use local @actions/artifact package for Node.js 24 testing Additional commits viewable in compare view  Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: lfit.gh2gerrit <[email protected]> Change-Id: If3203b06393869c2c8b70ade669d468a25efcc97 GitHub-PR: #33 GitHub-Hash: 941495290b069787
Similarly to the change in
upload-artifact:v3(link) uses Node 16 which is deprecated.v3-node20(link) has been available for a while which uses Node 20 so we should reflect this in the documentation.