Skip to content

Create ADR for integrating cache functionality to setup-node action #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxim-lobanov merged 6 commits into from
Jun 29, 2021
Merged

Create ADR for integrating cache functionality to setup-node action #266

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
24265e1
Create 0000-caching-dependencies.md
May 21, 2021
8c35c6c
Update 0000-caching-dependencies.md
May 21, 2021
5fddb2d
Update 0000-caching-dependencies.md
May 24, 2021
ae26aaf
Update 0000-caching-dependencies.md
May 26, 2021
1bf3053
Update docs/adrs/0000-caching-dependencies.md
maxim-lobanov May 26, 2021
5929471
Update 0000-caching-dependencies.md
Jun 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update 0000-caching-dependencies.md
  • Loading branch information
Maxim Lobanov committed May 26, 2021
commit ae26aaf1b56fb80d170677751f3399908c8eb107
1 change: 0 additions & 1 deletion docs/adrs/0000-caching-dependencies.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ We don't persue the goal to provide wide customization of caching in scope of `a
- Add optional input `package-lock-path` that will allow to specify path to `package-lock.json` file path:
- If input is not defined, action will try to search `package-lock.json` or `yarn.lock` (npm 7.x supports `yarn.lock` files) files in the repository root and throw error if no one is found
- If input contains file path, action will use the specified file
- If input contains folder path, action will try to search `package-lock.json` file in the specified folder
- if input contains wildcards (like `**/package-lock.json`), hash of multiple files will be used
- The hash of file provided in `package-lock-path` input will be used as cache key (the same approach like [actions/cache](https://github.com/actions/cache/blob/main/examples.md#node---npm) recommends)
- The following key cache will be used `${{ runner.os }}-npm-${{ hashFiles('<package-lock-path>') }}`
Expand Down