Skip to content

bugfix: Don't attempt to use Windows fallbacks on non-Windows OSes #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmitry-shibanov merged 5 commits into from
Apr 11, 2023
Merged

bugfix: Don't attempt to use Windows fallbacks on non-Windows OSes #718

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
57b2336
bugfix: Don't attempt to use Windows fallbacks on non-Windows OSes
domdomegg Mar 15, 2023
d08b818
Add tests
domdomegg Mar 15, 2023
c78a7a1
Run pre-checkin script
domdomegg Mar 16, 2023
99d00d9
Merge branch 'actions:main' into limit-windows-fallback-to-windows-en…
domdomegg Apr 4, 2023
536c162
run formatter
dmitry-shibanov Apr 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Run pre-checkin script
  • Loading branch information
@domdomegg
domdomegg committed Mar 16, 2023
commit c78a7a14b31048713e3a603719916b6813523fcb
32 changes: 17 additions & 15 deletions __tests__/nightly-installer.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ describe('setup-node', () => {
const workingUrls = [
`https://nodejs.org/download/nightly/v${versionSpec}/win-x64/node.exe`,
`https://nodejs.org/download/nightly/v${versionSpec}/win-x64/node.lib`
]
];

inputs['node-version'] = versionSpec;
inputs['always-auth'] = false;
Expand All @@ -296,25 +296,25 @@ describe('setup-node', () => {
findSpy.mockImplementation(() => '');
findAllVersionsSpy.mockImplementation(() => []);

dlSpy.mockImplementation(async (url) => {
dlSpy.mockImplementation(async url => {
if (workingUrls.includes(url)) {
return '/some/temp/path'
return '/some/temp/path';
}

throw new tc.HTTPError(404)
throw new tc.HTTPError(404);
});
const toolPath = path.normalize(
'/cache/node/13.13.1-nightly20200415947ddec091/x64'
);
cacheSpy.mockImplementation(async () => toolPath);
mkdirpSpy.mockImplementation(async () => {})
cpSpy.mockImplementation(async () => {})
mkdirpSpy.mockImplementation(async () => {});
cpSpy.mockImplementation(async () => {});

await main.run();

workingUrls.forEach(url => {
expect(dlSpy).toHaveBeenCalledWith(url);
})
});
expect(cnSpy).toHaveBeenCalledWith(`::add-path::${toolPath}${osm.EOL}`);
});

Expand All @@ -328,7 +328,7 @@ describe('setup-node', () => {
const workingUrls = [
`https://nodejs.org/download/nightly/v${versionSpec}/win-x64/node.exe`,
`https://nodejs.org/download/nightly/v${versionSpec}/win-x64/node.lib`
]
];

inputs['node-version'] = versionSpec;
inputs['always-auth'] = false;
Expand All @@ -338,26 +338,28 @@ describe('setup-node', () => {
findSpy.mockImplementation(() => '');
findAllVersionsSpy.mockImplementation(() => []);

dlSpy.mockImplementation(async (url) => {
dlSpy.mockImplementation(async url => {
if (workingUrls.includes(url)) {
return '/some/temp/path'
return '/some/temp/path';
}

throw new tc.HTTPError(404)
throw new tc.HTTPError(404);
});
const toolPath = path.normalize(
'/cache/node/13.13.1-nightly20200415947ddec091/x64'
);
cacheSpy.mockImplementation(async () => toolPath);
mkdirpSpy.mockImplementation(async () => {})
cpSpy.mockImplementation(async () => {})
mkdirpSpy.mockImplementation(async () => {});
cpSpy.mockImplementation(async () => {});

await main.run();

workingUrls.forEach(url => {
expect(dlSpy).not.toHaveBeenCalledWith(url);
})
expect(cnSpy).toHaveBeenCalledWith(`::error::Unexpected HTTP response: 404${osm.EOL}`);
});
expect(cnSpy).toHaveBeenCalledWith(
`::error::Unexpected HTTP response: 404${osm.EOL}`
);
});

it('does not find a version that does not exist', async () => {
Expand Down
Loading