Skip to content

Enhance reading from .python-version #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 21, 2025
+99 −41
Merged

Enhance reading from .python-version #787

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
13399d0
Enhance reading from .python-version
krystof-k Jan 3, 2024
e73db46
Fix typos
krystof-k Jan 3, 2024
795bdd5
Fix lint
krystof-k Apr 9, 2025
2cd6a52
Add built files
krystof-k May 14, 2025
eff48d1
Don't use EOL versions in `utils.test.ts`
krystof-k May 14, 2025
34bb731
Fix Prettier
krystof-k May 14, 2025
cf275fe
Don't use unreleased versions in `utils.test.ts`
krystof-k May 19, 2025
68b6f20
Update versions in `utils.test.ts` again
krystof-k May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't use unreleased versions in utils.test.ts
  • Loading branch information
@krystof-k
krystof-k committed May 19, 2025
commit cf275fe24d3d664ab46fbec3c3ed0c13d45bdd56
10 changes: 5 additions & 5 deletions __tests__/utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,13 +124,13 @@ describe('Version from file test', () => {
const pythonVersionFileName = 'python-version.file';
const pythonVersionFilePath = path.join(tempDir, pythonVersionFileName);
const pythonVersionFileContent =
'3.15/envs/virtualenv\r# 3.15\n3.14\r\n3.13\r\n 3.12 \r\n';
'3.14/envs/virtualenv\r# 3.14\n3.13\r\n3.12\r\n 3.11 \r\n';
fs.writeFileSync(pythonVersionFilePath, pythonVersionFileContent);
expect(_fn(pythonVersionFilePath)).toEqual([
'3.15',
'3.14',
'3.13',
'3.12'
'3.12',
'3.11'
]);
}
);
Expand Down Expand Up @@ -206,9 +206,9 @@ describe('Version from file test', () => {
async _fn => {
const toolVersionFileName = '.tool-versions';
const toolVersionFilePath = path.join(tempDir, toolVersionFileName);
const toolVersionContent = 'python v3.14.2';
const toolVersionContent = 'python v3.13.2';
fs.writeFileSync(toolVersionFilePath, toolVersionContent);
expect(_fn(toolVersionFilePath)).toEqual(['3.14.2']);
expect(_fn(toolVersionFilePath)).toEqual(['3.13.2']);
}
);

Expand Down
Loading