Fix asset path for newer version of xdan-datetimepicker-rails, subsequently datetimepicker #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/xdan/datetimepicker repo changed asset to jquery.datetimepicker.full.js Signed-off-by: Chris Desch <[email protected]>
Signed-off-by: Chris Desch <[email protected]>
Merged
Fivell
added a commit
that referenced
this pull request
Mar 10, 2016
Fix asset path for newer version of xdan-datetimepicker-rails, subsequently datetimepicker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Repos
After version
2.4.5thejquery.datetimepicker.jsreceived braking changes in this commit ( subsequently ) and was addedjquery.datetimepicker.full.js. This change switches the asset path to the newjquery.datetimepicker.full.jsand bumps the version of xdan-datetimepicker-rails to pull the latest version.This change request fixes issue #12 - The work around to that issue to force your app gemfile to use
gem 'xdan-datetimepicker-rails', '2.4.5'or lower.@Fivell please consider accepting or commenting on this pull request as currently the gem is broken when installing
active_admin_datetimepickerfresh.