Skip to content

Conversation

KrlSbin
Copy link

@KrlSbin KrlSbin commented Apr 18, 2017

Now filtering by time (hours and minutes) is applied correctly.
In bundle with AA these fields values were overridden by ransack patch:

  config.add_predicate 'gteq_datetime',
    arel_predicate: 'gteq',
    formatter: ->(v) { v.beginning_of_day }

  config.add_predicate 'lteq_datetime',
  	arel_predicate: 'lt',
  	formatter: ->(v) { v + 1.day }

@coveralls
Copy link

coveralls commented Apr 18, 2017

Coverage Status

Coverage decreased (-14.4%) to 80.144% when pulling a9414f6 on NoPos:Fix-names-for-date-time-range-input into 0fc0f23 on activeadmin-plugins:master.

@Fivell Fivell requested a review from workgena April 18, 2017 15:30
@Fivell
Copy link
Member

Fivell commented Apr 18, 2017

@NoPos , rebase pls

Now filtering by time (hours and minutes) is applied correctly.
@coveralls
Copy link

coveralls commented Apr 18, 2017

Coverage Status

Coverage increased (+0.08%) to 95.238% when pulling 4577af5 on NoPos:Fix-names-for-date-time-range-input into f59ebdd on activeadmin-plugins:master.

@Fivell Fivell requested review from gigorok and senid231 April 18, 2017 17:19
@workgena workgena merged commit 4eb0f6c into activeadmin-plugins:master Apr 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants