Skip to content

Conversation

KrlSbin
Copy link

@KrlSbin KrlSbin commented Sep 29, 2017

No description provided.

@coveralls
Copy link

coveralls commented Sep 29, 2017

Coverage Status

Coverage decreased (-4.8%) to 90.476% when pulling ddd5767 on NoPos:support_active_admin_1.1.0 into 5721ea4 on activeadmin-plugins:master.

@workgena
Copy link
Contributor

workgena commented Sep 29, 2017

@NoPos looks like document-ready function is broken. Try to replace it

in file "active_admin_datetimepicker.js.coffee" replace all from line 17
"$(document).on 'ready turbolinks:load', ->" to

@initXdanDateTimePickerPlugin = () ->
  setupDateTimePicker $('body')
  $(document).on 'has_many_add:after', '.has_many_container', (e, fieldset) ->
    setupDateTimePicker fieldset

$(document).ready ->
  initXdanDateTimePickerPlugin()

$(document).on 'turbolinks:load', ->
  initXdanDateTimePickerPlugin()

@workgena workgena mentioned this pull request Sep 29, 2017
@coveralls
Copy link

coveralls commented Sep 29, 2017

Coverage Status

Coverage remained the same at 95.238% when pulling ecb9446 on NoPos:support_active_admin_1.1.0 into 5721ea4 on activeadmin-plugins:master.

Copy link
Contributor

@workgena workgena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also fixes #35

@coveralls
Copy link

coveralls commented Sep 29, 2017

Coverage Status

Coverage remained the same at 95.238% when pulling 612b11d on NoPos:support_active_admin_1.1.0 into 5721ea4 on activeadmin-plugins:master.

@Fivell Fivell merged commit 94a229f into activeadmin-plugins:master Sep 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants