loosen activeadmin restriction to allow 2.0

[iarie]

https://github.com/activeadmin/activeadmin/blob/master/CHANGELOG.md

Activeadmin 2.0 do not сontain any major changes except ruby 2.3 support drop, this gem should be fine

[coveralls]

Coverage increased (+1.3%) to 96.109% when pulling 9250cf6 on iarie:patch-1 into 9404671 on activeadmin-plugins:master.

[coveralls]

Coverage increased (+1.04%) to 95.817% when pulling 52c4807 on iarie:patch-1 into 9404671 on activeadmin-plugins:master.

[deivid-rodriguez]

Hi @iarie, sorry if the changelog is confusing.

The ruby 2.3 support drop has not yet been released. The list of changes in the 2.0 release can be found mainly under the 2.0.0.rc1 entry. The fact that the 2.0.0 entry says "No changes" means that there were no user visible changes between 2.0.0.rc2 and 2.0.0 final.

[workgena]

I'll take a look at this PR tomorrow 🌞

[deivid-rodriguez]

If the intention is to not allow future ActiveAdmin 3.0.0 prereleases, then the correct way to do that is:

spec.add_dependency "activeadmin", ">= 1.1", "< 3.a"

[iarie]

Thank you, my intention was exactly like that

[iarie]

@deivid-rodriguez hi, yes but there are no major changes in rc1 section as well, so I thought this gem should work fine on AA 2.0

[deivid-rodriguez]

@deivid-rodriguez hi, yes but there are no major changes in rc1 section as well, so I thought this gem should work fine on AA 2.0

Ah, ok. Since you said that the main breaking change was dropping support for ruby 2.3, I thought you had misunderstood the changelog 👍. It sounds like the only thing needed to get CI green would be to drop Rails 4.2 support in this plugin just like AA did.

[workgena]

Firstly, @iarie thanx for contribution.

I've found what was the problem with ActiveAdmin 2.0 and fixed in followed commit.

Then I decided to remove 2.3 ruby support due to:

Ruby Maintenance Branches

Ruby 2.3

status: eol
release date: 2015-12-25
EOL date: 2019-03-31

---

Rails Supported versions

For major security issues, all releases in the current major series, and the last release in the additional major series will receive patches and new versions. This is currently 5.2.x, 5.1.x, 5.0.x and 4.2.x.

[workgena]

I'll do version bump after merging this PR. Before that I want to check it manually.

[workgena]

Checked it manually. Works fine.

@iarie @deivid-rodriguez If you do not have any other comments on this PR, I'll merge it.

[iarie]

Thank you, @workgena!