Fix LIKE predicates wildcard escaping for SQLite and other non-MySQL/PostgreSQL databases #1583
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Ransack's LIKE-based predicates (
*_cont
,*_not_cont
,*_start
,*_end
, etc.) were not properly escaping wildcard characters (%
,_
,\
) in SQLite and other non-MySQL/PostgreSQL databases. This caused unintended matches when search values contained these special characters.For example, searching for
%_
would match any record due to the wildcards being treated as SQL pattern characters instead of literal characters:Solution
This PR implements consistent wildcard escaping across all database adapters by:
ActiveRecord::Base.sanitize_sql_like
in theescape_wildcards
methodESCAPE '\'
when escaped wildcards are present in LIKE predicatesChanges
Core Implementation
lib/ransack/constants.rb
: Updatedescape_wildcards
to use Rails' built-insanitize_sql_like
methodlib/ransack/nodes/condition.rb
: Enhancedformat_predicate
to automatically add ESCAPE clause when neededTest Updates
spec/ransack/predicate_spec.rb
: Updated test expectations for SQLite to include ESCAPE clauses and added comprehensive wildcard escaping test coverageAfter Fix
Verification
This fix ensures that wildcard characters in search values are treated as literal characters consistently across all database adapters, making Ransack's search behavior predictable and secure.
Additional instructions:
Fixes #1581
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.