-
-
Notifications
You must be signed in to change notification settings - Fork 114
tests: adds test function for IdnaTestV2.json #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@miguelteixeiraa Would you add it to https://github.com/ada-url/idna ? We eventually want to rely on ada-url/idna for ada. |
Makes sense, good idea! |
Done! |
@miguelteixeiraa Why did you close it here? In my view, it belongs at both places. Your work here was good and relevant. Of course, here you were testing our ICU-based implementation, but no matter. My understanding is that your tests ought to pass everywhere (or, else, we need to figure something out). |
There is 1 test case we are failing at the moment.
|
We moved is_forbidden_domain_code_point check to outside of if (output.has_value()) {
if (std::any_of(output.value().begin(), output.value().end(), ada::unicode::is_forbidden_domain_code_point)) {
output = std::nullopt;
}
} |
Is it okay to remove the ada_really_inline constexpr from is_forbidden_domain_code_point? I'm getting linkage problems. |
…_point to fix linkage issues in tests
@miguelteixeiraa This will need to be updated because we did major surgery on the code. |
Let me see if I can integrate the code in the other PR. |
I am going to push the content of this PR into #216 It will be less trouble for everyone. You may close this PR. |
ref: #222
The good news is that almost all tests cases are passing.