Skip to content

fix aarch64 build errors #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anonrig merged 1 commit into from
Oct 6, 2024
Merged

fix aarch64 build errors #749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix aarch64 build errors
  • Loading branch information
@anonrig
anonrig committed Oct 6, 2024
commit a65c34608601f034295922748f31d840d5d0f804
4 changes: 3 additions & 1 deletion .github/workflows/aarch64.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ jobs:
distro: ubuntu22.04
install: |
apt-get update -q -y
apt-get install -y cmake make g++ ninja-build git
apt-get install -y cmake make g++-12 ninja-build git gcc-12
ln -s -f /usr/bin/gcc-12 /usr/bin/gcc
ln -s -f /usr/bin/g++-12 /usr/bin/g++
run: |
cmake -DCMAKE_CXX_STANDARD=20 -B build
cmake --build build
Expand Down
4 changes: 2 additions & 2 deletions include/ada/helpers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ bool overlaps(std::string_view input1, const std::string& input2) noexcept;
* Return the substring from input going from index pos1 to the pos2 (non
* included). The length of the substring is pos2 - pos1.
*/
ada_really_inline constexpr std::string_view substring(const std::string& input,
ada_really_inline constexpr std::string_view substring(std::string_view input,
size_t pos1,
size_t pos2) noexcept {
#if ADA_DEVELOPMENT_CHECKS
Expand All @@ -112,7 +112,7 @@ ada_really_inline constexpr std::string_view substring(const std::string& input,
abort();
}
#endif
return std::string_view(input.data() + pos1, pos2 - pos1);
return input.substr(pos1, pos2 - pos1);
}

/**
Expand Down