-
-
Notifications
You must be signed in to change notification settings - Fork 116
implement URLPattern #785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
implement URLPattern #785
Changes from 1 commit
Commits
Show all changes
164 commits
Select commit
Hold shift + click to select a range
80cb760
implement URLPattern skeleton
anonrig fc4b193
use correct value for clang-format
anonrig cd9df5e
fix build errors
anonrig 09c3f42
create url_pattern-inl.h
anonrig 6656757
add canonicalize methods
anonrig 686af7d
add ada::parse_url_pattern function
anonrig 3c08805
add more comments
anonrig 66da95c
implement getters
anonrig 8377009
add has_regexp_groups()
anonrig 61f4b67
start implementing tokenizer & tokenize
anonrig fe3af13
add initial parser_url_pattern method
anonrig 1262f8c
add todos and remove redundant qualifiers
anonrig 20691e3
implement escape pattern
anonrig eed6d80
add CompileComponentOptions
anonrig f153e00
minor fixes for add-url-pattern (#800)
lemire 7dbf175
rename commits
anonrig 5f36b46
add more parse_url_pattern
anonrig 4619c9d
rename url_pattern class
anonrig 5cdb6db
complete parse_url_pattern implementation
anonrig 5f28a37
add `_component` suffix to components
anonrig 20d7529
remove unnecessary void
anonrig 16aace3
implement generate regular expression methods
anonrig 14d217c
continue working on parser
anonrig 4a31b3f
fix build error
anonrig f10d3b2
implement constructor string parser
anonrig 4c20080
implement all of tokenizer's functions
anonrig 74f72fd
fix build errors
anonrig 969c87a
fix warnings
anonrig 6276ce8
complete tokenizer
anonrig 5f02b24
implement escape_regexp_string
anonrig f55e3f5
implement generate_pattern_string
anonrig cc73e97
fix compiler warnings
anonrig ca60161
semi-implement match
anonrig 1a47532
complete one more todo
anonrig a67fe01
simplify create_component_match_result
anonrig 37dc747
simplify
anonrig d4d843d
use correct inputs for match/exec/test
anonrig 5c212d7
rename wpt_tests to wpt_url_tests
anonrig d33f228
add wpt_urlpattern_tests skeleton
anonrig 530deb4
add first test
anonrig f1e04ce
Build fixes (#801)
lemire a10ba16
fix 2 bugs
anonrig b67580d
fix linter issues
anonrig 42d6c32
fix 2 more bugs
anonrig 8d8acb2
more progress on missing features
anonrig ac0817e
move url_pattern_helpers to separate file
anonrig 8523594
fix build errors
anonrig 096e159
use url_pattern_encoding_callback
anonrig f711faf
fix url pattern constructor error
anonrig fc5b020
fix more issues
anonrig 690a14a
add initial version of wpt test runner
anonrig 4f1dc9b
simplify json logic (#802)
lemire 21109d1
add fuzzer
anonrig 8929462
removing the reset
lemire 6759d37
update ada idna
anonrig e8897d9
use ada idna method for valid name code point
anonrig 4e96bbe
fix add part implementation
anonrig 43c806d
fix invalid access errors
anonrig 029e17f
implement tests correctly
anonrig c4c373b
improve test runner
anonrig 4b3f34d
add url_pattern_init to_string() method
anonrig 8d4994c
update WPT tests
anonrig 5e6f934
fix last remaining todo
anonrig 71468e2
simplify test runner
anonrig 6a4c9a5
minor fixes
lemire fd6d1d4
some reworking
lemire 7dca1de
make sure to skip invalid tests
anonrig 6d38085
remove std::ranges::iota due to clang
anonrig abb2af0
add more fuzzing coverage
anonrig a0df533
try to fix windows issues
anonrig aeb4699
remove unnecessary copy
anonrig 1eeab05
start testing the validity of the correct responses
anonrig 208c2ff
fix couple of bugs
anonrig 664ed1c
fix invalid ascii checks
anonrig 60c4015
make pattern generation more verbose
anonrig 5e989f0
fix regex error
anonrig 5539349
remove semicolon due to -Werror,-Wextra-semi
anonrig 04252cd
guarding regex call (#805)
lemire 3eac233
add more logging
anonrig 3f7536c
change ada_idna to char32_t
anonrig 602a565
remove try/catch
anonrig fc3e76e
make canonicalize_ methods more flexible
anonrig 9407a49
fix change_state
anonrig 6d8e960
fix invalid substr call
anonrig 67fb323
fix generate_pattern_string impl
anonrig dbd003d
fix more small issues
anonrig 8619179
improve url_pattern_init::process
anonrig a4f0c42
correctly computing the next code point (#808)
lemire 099fb43
adding checks
lemire 049dd11
use std string view to avoid copy
anonrig 6b29fed
use next_index instead of index
anonrig 61f45be
highlight the error message
anonrig d2bcf67
better decoding
lemire e997a28
I think that the test is in error (#810)
lemire 6e96857
remove invalid WPT test data
anonrig 188e171
remove invalid assertion
anonrig 5682bf1
fix ipv6 address canonicalize
anonrig 67f9708
fix canonicalize_ipv6_hostname
anonrig 681bf67
simplify test runner
anonrig 3304dd0
fix test runner
anonrig 40f85e3
add a todo
anonrig fdb044e
remove invalid test case
anonrig 8ee26f4
add tests for expected object
anonrig 7f4acf2
fix hostname tests
anonrig 505f526
complete match implementation
anonrig 6f284c4
fix empty component tests
anonrig d928625
revert some wpt changes
anonrig 64c6968
add some optional result logging (#812)
lemire 8090940
lint
lemire f204a8c
fixing logging
lemire d7b92eb
removing diagram printout
fc884cb
fix asan build errors
anonrig 77f44d3
simpler version of the yagiz/add-url-pattern branch (#815)
lemire ab71fa0
simplify implementation
anonrig ca66004
improve url_pattern_part emplace_back calls
anonrig b2d9e70
fix url_pattern_component constructor
anonrig baeafc6
remove the usage of ada.h inside src
anonrig 487582d
move all helper methods to url_pattern.cpp
anonrig ffee76c
fix urlpatterntestdata.json
anonrig 0100006
fix build errors
anonrig 757683b
add missing check
anonrig 8dc937e
more tests (#817)
lemire 53ba80f
fix assertion error
anonrig edbf6c0
don't move function calls
anonrig 5f74dd3
fix token reference asan error
anonrig a5580c7
another test (#818)
lemire db7acf9
simplify parser and tests
anonrig c60c2dc
remove unnecessary duplicate_name method
anonrig 385f554
convert Token to class
anonrig dab41f6
minor cleanups
anonrig cf69585
remove invalid std::move
anonrig bd9655d
simplify parser
anonrig 393f515
remove invalid pathname WPT
anonrig 64f66c6
leave some todos for WPT
anonrig 1f563d4
complete inputs parsing
anonrig 52c33b5
removed duplicated code
anonrig 6ae710b
merge error enums
anonrig 1b59155
fix a boolean operation
anonrig dd20066
update urlpatterntestdata.json
anonrig 528027c
remove unnecessary assertions
anonrig 65fe0b6
removing GLIBCXX debug
613d60d
updating macos ci
943f0aa
indent
9bb11ad
keeping only static
5b1de58
improve wpt runner
anonrig 1ec8ea0
fix match
anonrig c858831
add assertions for object return
anonrig 36a7b72
check __cpp_lib_format
lemire ff2bf00
adding version header (#824)
lemire 0feb9a6
fix match related bugs
anonrig 57accd5
fix port canonicalize
anonrig 67f9988
fix port setting caused by url parser bug
anonrig 9deaa41
add temporary check for special schemes
anonrig d47ca13
revert opaque host change
anonrig 14e6c53
fix match when input needs to be parsed
anonrig 6f2838f
fix match hash and search prefix
anonrig 89c8bea
fix internal assertion
anonrig e3f4fe2
improve wpt test runner
anonrig 8b8d5e6
improve regexp matching
anonrig a47d8c5
fix wpt testrunner
anonrig b620b09
fix test implementation
anonrig 36a9097
add half-working match_result
anonrig 87def0a
improve regex matching
anonrig 61728b2
remove invalid WPT test
anonrig File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix asan build errors
- Loading branch information
commit fc884cb62f2d4f9d5e811c33de3b4cecc3f2bc0f
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.