Skip to content

move implementation to header files #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anonrig merged 8 commits into from
Jan 24, 2025
Merged

move implementation to header files #847

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7a62fa9
move implementation to header files
anonrig Jan 23, 2025
58b6301
get rid of regex_provider arguments
anonrig Jan 23, 2025
ed0a1b3
avoid unnecessary copy
anonrig Jan 23, 2025
2fbdd48
reorg the headers for a cleaning design
lemire Jan 24, 2025
cc315e1
lint
lemire Jan 24, 2025
c71b4e7
more cleaning
lemire Jan 24, 2025
7904c75
lint
lemire Jan 24, 2025
c8bf16f
lint
lemire Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
avoid unnecessary copy
  • Loading branch information
@anonrig
anonrig committed Jan 23, 2025
commit ed0a1b3db06dce992b9e505ba2950641fe7b12cf
3 changes: 2 additions & 1 deletion include/ada/url_pattern_helpers-inl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -785,7 +785,8 @@ tl::expected<std::vector<url_pattern_part>, errors> parse_pattern_string(
template <url_pattern_regex::regex_concept regex_provider>
bool protocol_component_matches_special_scheme(
url_pattern_component<regex_provider>& component) {
auto regex = component.regexp;
// let's avoid unnecessary copy here.
auto& regex = component.regexp;
return regex_provider::regex_match("http", regex) ||
regex_provider::regex_match("https", regex) ||
regex_provider::regex_match("ws", regex) ||
Expand Down
Loading