Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add required template for friend classes
  • Loading branch information
anonrig committed Jan 30, 2025
commit 32c0092c1b11e861e4f9e5e34c29b3a973463d78
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ Runtimes like Node.js and Cloudflare Workers use the V8 regex engine, which is s

```cpp
// Define a regex engine that conforms to the following interface
// For eample we will use v8 regex engine
// For example we will use v8 regex engine

class v8_regex_provider {
public:
Expand All @@ -215,7 +215,7 @@ class v8_regex_provider {
};

// Define a URLPattern
auto pattern = ada::parse_url_pattern<v8_regex_provider>(("/books/:id(\\d+)", "https://example.com");
auto pattern = ada::parse_url_pattern<v8_regex_provider>("/books/:id(\\d+)", "https://example.com");

// Check validity
if (!pattern) { return EXIT_FAILURE; }
Expand Down
3 changes: 2 additions & 1 deletion include/ada/url_pattern.h
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,8 @@ class url_pattern {
}
#endif // ADA_TESTING

friend tl::expected<url_pattern, errors> parser::parse_url_pattern_impl(
template <url_pattern_regex::regex_concept P>
friend tl::expected<url_pattern<P>, errors> parser::parse_url_pattern_impl(
std::variant<std::string_view, url_pattern_init> input,
const std::string_view* base_url, const url_pattern_options* options);

Expand Down
Loading