Skip to content

Separating_properties #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 10, 2021
Merged

Separating_properties #21

merged 2 commits into from
May 10, 2021

Conversation

jposada202020
Copy link
Contributor

Solves #16

@jposada202020 jposada202020 linked an issue May 3, 2021 that may be closed by this pull request
Support for averaging and sample time register #16
Closed
@jposada202020 jposada202020 mentioned this pull request May 3, 2021
Closed
@jposada202020 jposada202020 requested a review from evaherrada May 3, 2021 22:20
@ladyada
Copy link
Member

ladyada commented May 4, 2021

hihi have you tested this on hardware?

@jposada202020
Copy link
Contributor Author

No, I wish, flying blind here, the deal is I do the changes, @dherrada test :) see PR #17

@evaherrada
Copy link
Collaborator

Oh yah, I said I would test. Will do after I release some stuff

@jposada202020
Copy link
Contributor Author

Ok I add a new example. You could use the example included to test. @ladyada or @dherrada ? maybe :) Thank you!!

Expected Results:

Adafruit CircuitPython 6.2.0 on 2021-04-05; Adafruit Feather RP2040 with rp2040
>>> import cap1188_simpletest
Sensor Initial Congfiguration Values: 128
Setting Up Averages
Average: 1
Average: 2
Average: 4
Average: 8
Average: 16
Average: 32
Average: 64
Average: 128
Setting Up Samples
Sample: 320us
Sample: 640us
Sample: 1.28ms
Sample: 2.56ms
Setting Up Samples
Cycle: 35ms
Cycle: 70ms
Cycle: 105ms
Cycle: 140ms
Done!

evaherrada
evaherrada approved these changes May 10, 2021
View reviewed changes
Copy link
Collaborator

@evaherrada evaherrada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for testing!

@evaherrada evaherrada merged commit 00009f6 into adafruit:master May 10, 2021
@jposada202020
Copy link
Contributor Author

Thank you... :)

@jposada202020 jposada202020 deleted the separating_properties branch May 10, 2021 19:06
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request May 14, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@41b2432)
e6b56e1 
Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO08X_RVC to 1.0.5 from 1.0.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_BNO08x_RVC#3 from jposada202020/improxing_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_CAP1188 to 1.3.0 from 1.2.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_CAP1188#21 from jposada202020/separating_properties

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SH1107 to 1.2.0 from 1.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SH1107#5 from lesamouraipourpre/display_offset
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_EMC2101 to 1.1.8 from 1.1.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_EMC2101#17 from jposada202020/correcting_typo

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM6DS to 4.2.0 from 4.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM6DS#41 from jposada202020/adding_temperature_property

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP4728 to 1.2.0 from 1.1.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP4728#10 from codenio/feature/general_call

Updating https://github.com/adafruit/Adafruit_CircuitPython_SI4713 to 1.3.0 from 1.2.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_SI4713#18 from sheimers/master
  > "Increase duplicate code check threshold "
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evaherrada evaherrada evaherrada approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for averaging and sample time register

3 participants

@jposada202020 @ladyada @evaherrada