Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove self.backlight_inverted, use property
  • Loading branch information
kattni committed Nov 21, 2018
commit af6e0231e8acdd8ecffd6fa96e169e2924f2b5c8
3 changes: 1 addition & 2 deletions adafruit_character_lcd/character_lcd.py
Original file line number Diff line number Diff line change
Expand Up @@ -524,8 +524,7 @@ def __init__(self, rs, en, db4, db5, db6, db7, columns, lines,
# Setup backlight
if backlight_pin is not None:
self.backlight_pin.direction = digitalio.Direction.OUTPUT
if backlight_inverted:
self.backlight_pin.value = not backlight_inverted # Turn backlight on
self.backlight = True
super().__init__(rs, en, db4, db5, db6, db7, columns, lines)
# pylint: enable-msg=too-many-arguments

Expand Down
2 changes: 1 addition & 1 deletion adafruit_character_lcd/character_lcd_i2c.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
__version__ = "0.0.0-auto.0"
__repo__ = "https://github.com/adafruit/Adafruit_CircuitPython_CharLCD.git"


class Character_LCD_I2C(Character_LCD_Mono):
# pylint: disable=too-few-public-methods
"""Character LCD connected to I2C/SPI backpack using its I2C connection.
Expand Down Expand Up @@ -79,6 +80,5 @@ def __init__(self, i2c, columns, lines, backlight_inverted=False):
db6 = self._mcp.get_pin(5)
db7 = self._mcp.get_pin(6)
backlight_pin = self._mcp.get_pin(7)
self.backlight_inverted = backlight_inverted
super().__init__(reset, enable, db4, db5, db6, db7, columns, lines,
backlight_pin=backlight_pin, backlight_inverted=backlight_inverted)
1 change: 0 additions & 1 deletion adafruit_character_lcd/character_lcd_spi.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,5 @@ def __init__(self, spi, latch, columns, lines, backlight_inverted=False):
db6 = self._shift_register.get_pin(4)
db7 = self._shift_register.get_pin(3)
backlight_pin = self._shift_register.get_pin(7)
self.backlight_inverted = backlight_inverted
super().__init__(reset, enable, db4, db5, db6, db7, columns, lines,
backlight_pin=backlight_pin, backlight_inverted=backlight_inverted)