Updates play_file to work with 3.0 #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
May 22, 2018
| audio.play() | ||
| while audio.playing: | ||
| pass | ||
| if sys.implementation.version[0] == 3: |
There was a problem hiding this comment.
Do >= instead of == so it works on 4.0.0 and beyond.
|
@tannewt Done. My general intention is to remove the 2.x specific stuff once 3.0 is released. We're already so tight on memory that I think it would be worth it. We won't be updating 2.x eventually anyway so the lib can remain frozen as-is. |
|
@kattni removing after 3.0.0 is released sounds good to me! I just know I forget sometimes. :-) |
tannewt
approved these changes
May 22, 2018
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
May 25, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 2.0.0 from 1.2.2: > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#33 from kattni/cp-3-update > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#32 from kattni/cp-3-update Updating https://github.com/adafruit/Adafruit_CircuitPython_DotStar to 1.2.1 from 1.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#24 from dhalbert/speedups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still needs
touchiosupport as well as the recently updated version of LIS3DH to really work with 3.0, but both are external issues. Once in place, this lib should work with 3.0.