Implements colorsys from the standard library to add HLS and HSV to RGB support #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds HLS to RGB and HSV to RGB support via standard library colorsys module
|
Is this code from somewhere else or did you write it? We should make sure and keep the license info on it. |
|
It's a couple functions ripped out of colorsys.py in the anaconda3/lib folder. It didn't have the license info in the script itself. |
|
Looks like its from CPython: https://github.com/python/cpython/blob/3.4/Lib/colorsys.py Please add a comment saying so and refer to the license here: https://github.com/python/cpython/blob/3.4/LICENSE Thank you! |
|
Will that work? Thanks! |
|
Yup! Looks great! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will return tuple of RGB[0-255] values.