Skip to content

Conversation

FoamyGuy
Copy link
Contributor

I believe this are the necessary changes for this to get moved over to being colorsys.

I updated the gitignore, removed the cpython file, added the example script.

I don't believe I have access to rename the repo, but I think that is ready to be done after this is merged.

@FoamyGuy
Copy link
Contributor Author

It seems that we have some trouble building the docs.

Warning, treated as error:
/home/runner/work/Adafruit_CircuitPython_CPython/Adafruit_CircuitPython_CPython/docs/index.rst:17:toctree contains reference to document 'api' that doesn't have a title: no link will be generated
Error: Process completed with exit code 2.

I'm not really sure what this error is trying to indicate. I thought this SO question might be relavent: https://stackoverflow.com/questions/14079655/cannot-get-toctree-in-sphinx-to-show-link but I'm not sure after poking around some. Our other libraries don't seem to have titles in the rst files like the answer here is suggesting and they still build okay.

I will take a closer look in the next few days and try to make this match another libraries docs setup.


"""
`adafruit_cpython`
====================================================
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the title that was used before. I think you'll want something like this in colorsys.py.

@FoamyGuy
Copy link
Contributor Author

Thank you! got it building now.

@jposada202020
Copy link
Contributor

So happy for this :)

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tannewt tannewt merged commit 7067d92 into adafruit:master Mar 30, 2021
@evaherrada
Copy link
Collaborator

@tannewt Should I migrate the library name and everything to colorsys? I assume I need to change it in settings, then update the readthedocs thing and make sure it's deploying to pypi correctly

@tannewt
Copy link
Member

tannewt commented Apr 9, 2021

@dherrada Yes please!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants