Skip to content

Conversation

FoamyGuy
Copy link
Contributor

@FoamyGuy FoamyGuy commented Jul 7, 2023

This adds support for the change this core pr: adafruit/circuitpython#8136

There is still fallback logic so that devices that aren't on the same versions can still both work with the library

@tekktrik
Copy link
Member

@FoamyGuy is this intended to be drafted still?

@FoamyGuy FoamyGuy marked this pull request as ready for review July 24, 2023 13:36
@FoamyGuy
Copy link
Contributor Author

@tekktrik thank you. No it's ready now that the core PR is merged.

@tekktrik tekktrik self-requested a review July 24, 2023 14:08
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uses a new addition to the API, but in a way that is backward compatible. Nice! Looks good to me!

@tekktrik tekktrik merged commit 347a824 into adafruit:main Jul 28, 2023
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants