Skip to content

Fix/slice notation #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 1, 2021
Merged

Fix/slice notation #28

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ab02f7b
Updated to use slice notation for __setitem__
tekktrik Oct 30, 2021
7bcf182
Remove the ability to use slice stepping
tekktrik Oct 30, 2021
0c79155
Update code example in docstring
tekktrik Oct 30, 2021
27f9df3
Reformatting per pre-commit
tekktrik Oct 30, 2021
2656d7a
Corrected ValueError text formatting
tekktrik Nov 30, 2021
dc14672
Fix writing of slice to FRAM
tekktrik Nov 30, 2021
ae0264f
Reformatted per pre-commit
tekktrik Nov 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reformatting per pre-commit
  • Loading branch information
@tekktrik
tekktrik committed Oct 30, 2021
commit 27f9df3d468ec5e8d6263b88b55ca2059856dd2d
13 changes: 5 additions & 8 deletions adafruit_fram.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,9 +170,7 @@ def __setitem__(self, address, value):

if isinstance(address, int):
if not isinstance(value, int):
raise ValueError(
"Data must be a single integer for single addresses"
)
raise ValueError("Data must be a single integer for single addresses")
if not 0 <= address < self._max_size:
raise ValueError(
"Address '{0}' out of range. It must be 0 <= address < {1}.".format(
Expand All @@ -185,17 +183,16 @@ def __setitem__(self, address, value):
elif isinstance(address, slice):
if not isinstance(value, (bytes, bytearray, list, tuple)):
raise ValueError(
"Data must be a single integer, bytes, bytearray, list, or tuple for multiple addresses"
"Data must be a single integer, bytes, bytearray, list, \
or tuple for multiple addresses"
)
if (address.start is None) or (address.stop is None):
raise ValueError(
"Boundless slices are not supported"
)
raise ValueError("Boundless slices are not supported")
if (address.step is not None) and (address.step != 1):
raise ValueError("Slice stepping is not currently available.")
if (address.start < 0) or (address.stop > self._max_size):
raise ValueError(
"Slice '{0}:{1}' out of range. All addresses must be 0 <= address < {2}.".format(
"Slice '{0}:{1}' out of range. All addresses must be 0 <= address < {2}.".format( # pylint: disable=line-too-long
address.start, address.stop, self._max_size
)
)
Expand Down