Skip to content

Conversation

@jepler
Copy link
Contributor

@jepler jepler commented Aug 7, 2021

In #38 there was an unrelated pylint diagnostic:

examples/midi_inoutdemo.py:39:38: R1728: Consider using a generator instead 'tuple(c + 1 for c in midi.in_channel)' (consider-using-generator)

Do so.

Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dhalbert dhalbert merged commit caa8a2a into adafruit:main Aug 7, 2021
@dhalbert
Copy link
Contributor

dhalbert commented Aug 7, 2021

When I merged this, the merge run failed black. ? :( ?

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Aug 11, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_MacroPad to 1.3.3 from 1.3.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MacroPad#16 from apendley/extended_tone_demo

Updating https://github.com/adafruit/Adafruit_CircuitPython_MIDI to 1.4.2 from 1.4.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_MIDI#40 from jepler/no-reuse-exception
  > Merge pull request adafruit/Adafruit_CircuitPython_MIDI#39 from jepler/use-generator
  > Merge pull request adafruit/Adafruit_CircuitPython_MIDI#38 from EMATech/mtc

Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 5.1.1 from 5.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#87 from DynamicDevices/ajl/fix-multiple-pingreqs

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_Ducky
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants