Switch to using ConnectionManager #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladak
reviewed
Jan 19, 2024
brentru
requested changes
Feb 29, 2024
There was a problem hiding this comment.
@justmobilize This looks OK - did you test any of the tests on physical hardware, or on CPython?
@brentru I've tested on my |
|
@justmobilize Thanks for testing on hardware. Marking this as approved! |
brentru
approved these changes
Feb 29, 2024
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Mar 1, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP_ATcontrol to 0.11.0 from 0.10.2: > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#70 from justmobilize/remove-set-socket Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 7.6.0 from 7.5.9: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#197 from justmobilize/connection-manager Updating https://github.com/adafruit/Adafruit_CircuitPython_PyCamera to 1.2.0 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_PyCamera#31 from FoamyGuy/overlay_pos Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
adafruit_requeststo use Adafruit_CircuitPython_ConnectionManager for socket handling. As well as clean up examples