Check for inconsistent CIRCUITPY and display CircuitPython update message #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review from anyone. |
TheKitty
approved these changes
Feb 21, 2024
brentru
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
check_for_update_needed() method addresses key issue described in the PR.
On L292, you may want to const() the FS size (1000000) as it's not going to be modified by a user and can save some space (likely negligible though, just something I noticed)
if circuitpy_stat[1] * circuitpy_stat[2] > 1000000:
|
@brentru Since it doesn't have a name, |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 22, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_PyCamera to 1.0.0 from 0.0.9: > Merge pull request adafruit/Adafruit_CircuitPython_PyCamera#29 from dhalbert/circuitpython-update-check > add basic_camera code > Merge pull request adafruit/Adafruit_CircuitPython_PyCamera#26 from adafruit/fix-spdx > Merge pull request adafruit/Adafruit_CircuitPython_PyCamera#25 from adafruit/focus_stack Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_ConnectionManager Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for a CIRCUITPY drive that is too large, which indicates that CIRCUITPY was created by a version of CircuitPython older than 9.0.0 beta 2. If so, display and print a message, and hang.
Punctuation has changed slightly since this screen shot.