Skip to content

Fix _irq_handler #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hathach merged 1 commit into from
Oct 16, 2023
Merged

Fix _irq_handler #791

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions libraries/RotaryEncoder/SwRotaryEncoder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,14 +120,14 @@ void SwRotaryEncoder::clearAbs(void)

void SwRotaryEncoder::_irq_handler(void)
{
uint32_t val = NRF_GPIO->IN;
uint8_t bita = bitRead(val, _pina);
uint8_t bita = digitalRead(_pina);
uint8_t bitb = digitalRead(_pinb);

if ( bita != _a_last)
{
int32_t step;

if ( bita != bitRead(val, _pinb) )
if ( bita != bitb )
{
step = 1;
}else
Expand Down