Skip to content

mutable polarity and phase on SPIDevice #10658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FoamyGuy wants to merge 2 commits into from
Closed

mutable polarity and phase on SPIDevice #10658

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6d140f
mutable polarity and phase on SPIDevice
FoamyGuy Oct 7, 2025
2f4a6f6
code format
FoamyGuy Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
code format
  • Loading branch information
@FoamyGuy
FoamyGuy committed Oct 7, 2025
commit 2f4a6f6a41ae7636ede924e2e6943cbbf201f337
24 changes: 12 additions & 12 deletions shared-bindings/adafruit_bus_device/spi_device/SPIDevice.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,17 +100,17 @@ static mp_obj_t adafruit_bus_device_spidevice_make_new(const mp_obj_type_t *type
//| polarity: int
//| """Polarity of the SPIDevice."""
static mp_obj_t adafruit_bus_device_spidevice_obj_get_polarity(mp_obj_t self_in) {
adafruit_bus_device_spidevice_obj_t *self = MP_OBJ_TO_PTR(self_in);
return MP_OBJ_NEW_SMALL_INT(common_hal_adafruit_bus_device_spidevice_get_polarity(self));
adafruit_bus_device_spidevice_obj_t *self = MP_OBJ_TO_PTR(self_in);
return MP_OBJ_NEW_SMALL_INT(common_hal_adafruit_bus_device_spidevice_get_polarity(self));
}
MP_DEFINE_CONST_FUN_OBJ_1(adafruit_bus_device_spidevice_get_polarity_obj, adafruit_bus_device_spidevice_obj_get_polarity);

static mp_obj_t adafruit_bus_device_spidevice_obj_set_polarity(mp_obj_t self_in, mp_obj_t polarity_obj) {
adafruit_bus_device_spidevice_obj_t *self = MP_OBJ_TO_PTR(self_in);
adafruit_bus_device_spidevice_obj_t *self = MP_OBJ_TO_PTR(self_in);

mp_int_t polarity = mp_obj_get_int(polarity_obj);
common_hal_adafruit_bus_device_spidevice_set_polarity(self, polarity);
return mp_const_none;
mp_int_t polarity = mp_obj_get_int(polarity_obj);
common_hal_adafruit_bus_device_spidevice_set_polarity(self, polarity);
return mp_const_none;
}
MP_DEFINE_CONST_FUN_OBJ_2(adafruit_bus_device_spidevice_set_polarity_obj, adafruit_bus_device_spidevice_obj_set_polarity);

Expand All @@ -121,17 +121,17 @@ MP_PROPERTY_GETSET(adafruit_bus_device_spidevice_polarity_obj,
//| phase: int
//| """Phase of the SPIDevice."""
static mp_obj_t adafruit_bus_device_spidevice_obj_get_phase(mp_obj_t self_in) {
adafruit_bus_device_spidevice_obj_t *self = MP_OBJ_TO_PTR(self_in);
return MP_OBJ_NEW_SMALL_INT(common_hal_adafruit_bus_device_spidevice_get_phase(self));
adafruit_bus_device_spidevice_obj_t *self = MP_OBJ_TO_PTR(self_in);
return MP_OBJ_NEW_SMALL_INT(common_hal_adafruit_bus_device_spidevice_get_phase(self));
}
MP_DEFINE_CONST_FUN_OBJ_1(adafruit_bus_device_spidevice_get_phase_obj, adafruit_bus_device_spidevice_obj_get_phase);

static mp_obj_t adafruit_bus_device_spidevice_obj_set_phase(mp_obj_t self_in, mp_obj_t phase_obj) {
adafruit_bus_device_spidevice_obj_t *self = MP_OBJ_TO_PTR(self_in);
adafruit_bus_device_spidevice_obj_t *self = MP_OBJ_TO_PTR(self_in);

mp_int_t phase = mp_obj_get_int(phase_obj);
common_hal_adafruit_bus_device_spidevice_set_phase(self, phase);
return mp_const_none;
mp_int_t phase = mp_obj_get_int(phase_obj);
common_hal_adafruit_bus_device_spidevice_set_phase(self, phase);
return mp_const_none;
}
MP_DEFINE_CONST_FUN_OBJ_2(adafruit_bus_device_spidevice_set_phase_obj, adafruit_bus_device_spidevice_obj_set_phase);

Expand Down
8 changes: 4 additions & 4 deletions shared-module/adafruit_bus_device/spi_device/SPIDevice.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,19 +24,19 @@ void common_hal_adafruit_bus_device_spidevice_construct(adafruit_bus_device_spid
}

void common_hal_adafruit_bus_device_spidevice_set_polarity(adafruit_bus_device_spidevice_obj_t *self, uint8_t polarity) {
self->polarity = polarity;
self->polarity = polarity;
}

void common_hal_adafruit_bus_device_spidevice_set_phase(adafruit_bus_device_spidevice_obj_t *self, uint8_t phase) {
self->phase = phase;
self->phase = phase;
}

uint8_t common_hal_adafruit_bus_device_spidevice_get_polarity(adafruit_bus_device_spidevice_obj_t *self) {
return self->polarity;
return self->polarity;
}

uint8_t common_hal_adafruit_bus_device_spidevice_get_phase(adafruit_bus_device_spidevice_obj_t *self) {
return self->phase;
return self->phase;
}

mp_obj_t common_hal_adafruit_bus_device_spidevice_enter(adafruit_bus_device_spidevice_obj_t *self) {
Expand Down