Don't throw error if ForwardContext is not available#730
Merged
calpt merged 3 commits intoadapter-hub:mainfrom Aug 10, 2024
Merged
Don't throw error if ForwardContext is not available#730calpt merged 3 commits intoadapter-hub:mainfrom
calpt merged 3 commits intoadapter-hub:mainfrom
Conversation
Fix Llama grad checkpointing training. Add quantized training test.
calpt
changed the title
lenglaender
approved these changes
Aug 8, 2024
Member
lenglaender
left a comment
lenglaender
left a comment
There was a problem hiding this comment.
Looks good to me! One last thing: The newly added test is currently skipped because in our pipeline we don't yet install bitsandbytes:
As soon as you have added this to the pipeline & the tests run through, you can merge it
dainis-boumber
added a commit
to ReDASers/adapters
that referenced
this pull request
Aug 30, 2024
Fixes in this PR: - Fix 'NoneType' error if context not available - Fix Llama grad checkpointing training. - Add quantized training test. Still existing limitation: - ForwardContext does not work with gradient checkpointing, ie methods such as reft or prefix tuning don't work with gradient checkpointing currently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes in this PR:
Still existing limitation: