Skip to content

Fixes integration tests #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
addshore merged 1 commit into from
Jul 31, 2016
Merged

Fixes integration tests #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/MediawikiApi.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,8 @@ public static function newFromPage( $url ) {
$tempClient = new Client( array( 'headers' => array( 'User-Agent' => 'addwiki-mediawiki-client' ) ) );
$pageXml = new SimpleXMLElement( $tempClient->get( $url )->getBody() );
$rsdElement = $pageXml->xpath( 'head/link[@type="application/rsd+xml"][@href]' );
$rsdXml = new SimpleXMLElement( $tempClient->get( $rsdElement[0]->attributes()['href'] )->getBody() );
return self::newFromApiEndpoint( $rsdXml->service->apis->api->attributes()->apiLink->__toString() );
$rsdXml = new SimpleXMLElement( $tempClient->get( (string) $rsdElement[0]->attributes()['href'] )->getBody() );
Copy link
Member

@JeroenDeDauw JeroenDeDauw Jul 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$tempClient? Who do I rage to about this? :)

Copy link
Member

@addshore addshore Jul 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect that would be me ;)

return self::newFromApiEndpoint( (string) $rsdXml->service->apis->api->attributes()->apiLink );
}

/**
Expand Down