Skip to content

Pure render for tree data, fixes React Canary useMemo/useState StrictMode #5835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 8, 2024
Merged

Pure render for tree data, fixes React Canary useMemo/useState StrictMode #5835

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c9e7d13
Pure render for useTreeData
snowystinger Feb 7, 2024
ea85e9e
adjust some more calls
snowystinger Feb 7, 2024
0257054
fix accumulation of build trees
snowystinger Feb 7, 2024
86d3a0f
better readability
snowystinger Feb 7, 2024
62a7fef
fix typo
snowystinger Feb 7, 2024
ca1545a
fix remaining broken tests
snowystinger Feb 7, 2024
c259466
revert canary testing changes
snowystinger Feb 8, 2024
ec10e60
fix lint
snowystinger Feb 8, 2024
46304e6
updating naming and making things a bit easier to read
LFDanLu Feb 8, 2024
173d02f
make sure a new map is always generated in insert for purity
LFDanLu Feb 8, 2024
8377a7c
make useTreeData always use and return a new Map
LFDanLu Feb 8, 2024
2103dd1
guard against empy array in remove
LFDanLu Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix lint
  • Loading branch information
@snowystinger
snowystinger committed Feb 8, 2024
commit ec10e60e1c6fa44a14ec2183de3a8db8fa926637
2 changes: 1 addition & 1 deletion packages/@react-stately/data/src/useTreeData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
*/

import {Key} from '@react-types/shared';
import {useMemo, useState} from 'react';
import {useState} from 'react';

export interface TreeOptions<T extends object> {
/** Initial root items in the tree. */
Expand Down