Skip to content

docs: correct application of themed code styling #2800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Westbrook merged 1 commit into from
Dec 14, 2022
Merged

docs: correct application of themed code styling #2800

Westbrook merged 1 commit into from
Dec 14, 2022

Conversation

@Westbrook
Copy link
Contributor

@Westbrook Westbrook commented Dec 13, 2022

Description

Ensure theme specific style application in code samples.

Related issue(s)

How has this been tested?

  • Test case 1
    1. Go here
    2. See the code sample highlighting
    3. Switch the theme color
    4. See the code sample highlighting
    5. Experience being able to read the code in all themes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2022

Branch Preview

@Westbrook Westbrook requested a review from nickschaap December 13, 2022 23:56
@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2022

Tachometer results

Currently, no packages are changed by this PR...

nickschaap
nickschaap approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@nickschaap nickschaap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks!! LGTM

@Westbrook Westbrook merged commit 9bab0fe into main Dec 14, 2022
@Westbrook Westbrook deleted the docs-code-themes branch December 14, 2022 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickschaap nickschaap nickschaap approved these changes

@hunterloftis hunterloftis Awaiting requested review from hunterloftis

@najikahalsema najikahalsema Awaiting requested review from najikahalsema

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Documentation has wrong code samples styles in Firefox

3 participants

@Westbrook @nickschaap