Fix for Bounding Box Issue #181
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… I add support for image elements correctly as currently its non generic
Revering because Tushar will fix this properly, and I need to take some older commits too to make this run, so removing. This reverts commit 2e1a7a7.
…ich crops in output (#173)
* fix testcases for offset/opacity as a percentage * support of percentage when specified in opacity,offset for stroke/fill properties * Revert "support of percentage when specified in opacity,offset for stroke/fill properties" This reverts commit 79c63cc. * Adding a new function name ParseAlphaValue for values between 0-1 * minor change in last commit
This reverts commit b5b67e0.
This reverts commit 798d7df.
This reverts commit cb64d5a.
* Part of changes required to support the fix for the bounding box issue. ViewBox dimensions will be used to shift the glyph. * Also removed UpdateViewBox() as it was not needed anymore.
* Changed the baseline for image.svg as the old one was using default values of width and height which are now being obtained after parsing the image data
This reverts commit 6103410.
* fix in circleCi testcase * minor fix in circleCi testcase
* Make code compatible to C++17 using std::variant * revert CMake changes * C++17 fix: remove cassert.h * Fix build issues with GDI+ * Use variadic macros for variant * Test C++17 on MSVS * potential build fix * Try using/templates * build fix * Revert CMakeFile changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Undid viewBox width and height being set to the glyph's width and height as they were being used to create the transformationMatrix in CTSNV, which eventually resulted in the glyphs being rendered as squares after the transformation was applied.
Transforms defined in the root svg node were being ignored previously by the SNV parser, which was causing a few fonts like GeckoEmoji to be rendered improperly. Added an else statement to store the transform and then apply it on the bounds.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: