Try/catch authentication for paiement module #607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #607 +/- ##
=======================================
Coverage 53.74% 53.74%
=======================================
Files 165 165
Lines 3606 3606
=======================================
Hits 1938 1938
Misses 1668 1668 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Marc-Andrieu
approved these changes
Oct 8, 2025
Member
Marc-Andrieu
left a comment
Marc-Andrieu
left a comment
There was a problem hiding this comment.
The goal of this PR is to handle the error when someone tries to generate a QR code whereas their phone has no security (no passwd or PIN code etc)
Rotheem
approved these changes
Nov 21, 2025
To handle the exceptions in a better way we should use the exceptions of the package local_auth when this gets released: flutter/packages#10147.
Marc-Andrieu
force-pushed
the
try-catch-authenticate
branch
from
6cd52e6 to
c68231e
Compare
Member
|
@julien4215 BTW flutter/packages#10147 is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To handle the exceptions in a better way we should use the exceptions of the package local_auth when this gets released: flutter/packages#10147.