Skip to content

[BUG]: PodTemplateSpec canonicalization issue #4852

@julienmancuso

Description

@julienmancuso

Describe the Bug

we just notice that when reconciling dynamo graph deployment we run into an issue that initContainer order got sorted again through container name [code pointer], this is causing some side-effect on our initContainer, as we have an assumption on the initContainer's ordering. Looking closer to the original issue #2469 , seems due to grove side validation webhook too sensitive, and the related issue on grove side ai-dynamo/grove#151 seems already solved by ai-dynamo/grove#152, so i wondering if it's reasonable to rm the sorting logic on the dynamo side ?

Steps to Reproduce

Create a dgd with init containers in a specific order

Expected Behavior

order should be respected

Actual Behavior

init containers get sorted by name

Environment

N/A

Additional Context

No response

Screenshots

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions