fix: Only check model name on etcd-registered endpoints

[jthomson04]

Fixes kv routing to multiple python workers. After creating one worker, creating another worker would cause etcd errors. This was because we were checking model names of every endpoint for the component. Some of the endpoints (such as load_metrics) aren't published to etcd, so this would fail. Instead, we can just check the model name for endpoints registered to etcd.

Closes: #1234

Summary by CodeRabbit

• Bug Fixes
  • Improved uniqueness checks to only apply to component instances with a "generate" endpoint, reducing unnecessary duplicate detection for other endpoints.
  • Enhanced error handling during model name uniqueness verification to avoid interruptions from network entry loading issues.

[coderabbitai]

"""

Walkthrough

The ensure_unique method in LocalModel was modified to handle errors from loading model entries more gracefully. It now only performs duplicate model name checks if the entry loads successfully, ignoring errors from the load operation. No changes were made to public APIs or exported declarations.

Changes

File(s)	Change Summary
lib/llm/src/local_model.rs	Updated ensure_unique to conditionally check for duplicate model names only when load_entry returns success, ignoring load errors.

Assessment against linked issues

Objective	Addressed	Explanation
Handle multiple workers registering without failing due to missing etcd entries (#1234)	✅

Poem

🐇 In the meadow where models roam free,
Errors once tripped on a missing key.
Now we hop past with a graceful skip,
Only checking when entries equip.
Multiple workers dance in delight,
No more crashes in the moonlight!
🌙✨

Code hops forward, smooth and bright!
"""

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f4d339a and 61fadc3.

📒 Files selected for processing (1)

• lib/llm/src/local_model.rs (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• lib/llm/src/local_model.rs

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: pre-merge-rust (lib/runtime/examples)
• GitHub Check: pre-merge-rust (.)
• GitHub Check: pre-merge-rust (lib/bindings/python)
• GitHub Check: Build and Test - vllm

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[grahamking]

We can't hard code an endpoint name like this. Adding a blocking "request changes" until we can figure it out in the thread Ryan started.

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[grahamking]

Can you update the title and description?