Skip to content

fix: Fix mypy errors on trtllm examples #1277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tanmayv25 merged 2 commits into from
May 30, 2025
Merged

fix: Fix mypy errors on trtllm examples #1277

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e33f145
Fix the typehints for mypy error
tanmayv25 May 30, 2025
4696864
format
tanmayv25 May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix the typehints for mypy error
  • Loading branch information
@tanmayv25
tanmayv25 committed May 30, 2025
commit e33f1453f0ba3e93fa4938e36c67f241a2c28e80
6 changes: 3 additions & 3 deletions examples/tensorrt_llm/common/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
import weakref
from enum import Enum
from queue import Queue
from typing import Callable, Optional, TypedDict, Union
from typing import Callable, Optional, TypedDict, Union, Coroutine, Any

logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -54,7 +54,7 @@ class ConversationMessage(TypedDict):
class ManagedThread(threading.Thread):
def __init__(
self,
task: Optional[Union[Callable[..., bool], weakref.WeakMethod]],
task: Optional[Union[Callable[..., Coroutine[Any, Any, bool]], weakref.WeakMethod]],
error_queue: Optional[Queue] = None,
name: Optional[str] = None,
loop: Optional[asyncio.AbstractEventLoop] = None,
Expand All @@ -74,7 +74,7 @@ def set_loop(self, loop: asyncio.AbstractEventLoop):

def run(self):
while not self.stop_event.is_set():
task: Optional[Union[Callable[..., bool], weakref.WeakMethod]] = self.task
task: Optional[Union[Callable[..., Coroutine[Any, Any, bool]], weakref.WeakMethod]] = self.task
if isinstance(task, weakref.WeakMethod):
task = task()
if task is None:
Expand Down