Skip to content

fix: Only check model name on etcd-registered endpoints #1283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nv-anants merged 2 commits into from
May 30, 2025
Merged

fix: Only check model name on etcd-registered endpoints #1283

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8d1dbb
Only check model name on generate endpoint
jthomson04 May 29, 2025
1ce1a9f
Only check endpoints in etcd
jthomson04 May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lib/llm/src/local_model.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,9 +184,11 @@ impl LocalModel {
};
for endpoint_info in component.list_instances().await? {
let network_name: ModelNetworkName = (&endpoint_info).into();
let entry = network_name.load_entry(&etcd_client).await?;
if entry.name != model_name {
anyhow::bail!("Duplicate component. Attempt to register model {model_name} at {component}, which is already used by {network_name} running model {}.", entry.name);

if let Ok(entry) = network_name.load_entry(&etcd_client).await {
if entry.name != model_name {
anyhow::bail!("Duplicate component. Attempt to register model {model_name} at {component}, which is already used by {network_name} running model {}.", entry.name);
}
}
}
Ok(())
Expand Down
Loading