fix: copy workspace as part of ci-min stage

[nv-anants]

Overview:

fix repo copy for ci min images, move up from dev image stage

 ls -l 
total 9504
-rw-r--r-- 1 root root 1005565 May 30 14:18 ATTRIBUTIONS-Go.md
-rw-r--r-- 1 root root 2002607 May 30 14:18 ATTRIBUTIONS-Python.md
-rw-r--r-- 1 root root 6239690 May 30 14:18 ATTRIBUTIONS-Rust.md
-rw-r--r-- 1 root root    1680 May 30 14:18 CODEOWNERS
-rw-r--r-- 1 root root    5488 May 30 14:18 CODE_OF_CONDUCT.md
-rw-r--r-- 1 root root    8099 May 30 14:18 CONTRIBUTING.md
-rw-r--r-- 1 root root  191169 May 30 14:18 Cargo.lock
-rw-r--r-- 1 root root    3280 May 30 14:18 Cargo.toml
-rw-r--r-- 1 root root    6789 May 30 14:18 Earthfile
-rw-r--r-- 1 root root   11357 May 30 14:18 LICENSE
-rw-rw-r-- 1 root root  148725 Jan 23 02:59 NVIDIA_Deep_Learning_Container_License.pdf
-rw-r--r-- 1 root root    7221 May 30 14:18 README.md
-rw-r--r-- 1 root root    1621 May 30 14:18 SECURITY.md
drwxr-xr-x 2 root root    4096 May 30 14:38 __pycache__
-rw-r--r-- 1 root root      29 May 30 14:18 codespell.txt
drwxr-xr-x 1 root root    4096 May 30 14:18 components
drwxr-xr-x 3 root root    4096 May 30 14:18 container
-rw-r--r-- 1 root root    1574 May 30 14:18 deny.toml
drwxr-xr-x 1 root root    4096 May 30 14:18 deploy
drwxr-xr-x 1 root root    4096 May 30 14:39 dist
drwxr-xr-x 9 root root    4096 May 30 14:18 docs
-rw-r--r-- 1 root root     448 May 30 14:18 dynamo.code-workspace
drwxr-xr-x 9 root root    4096 May 30 14:18 examples
-rw-r--r-- 1 root root    1375 May 30 14:18 hatch_build.py
drwxr-xr-x 1 root root    4096 May 30 14:18 launch
drwxr-xr-x 1 root root    4096 May 30 14:18 lib
-rw-r--r-- 1 root root    6593 May 30 14:18 pyproject.toml
-rw-r--r-- 1 root root      31 May 30 14:18 rust-toolchain.toml
drwxr-xr-x 1 root root    4096 May 30 14:39 target
-rw-r--r-- 1 root root      25 May 30 14:18 version.txt
drwxr-xr-x 1 root root    4096 May 30 14:25 wheels

Summary by CodeRabbit

• Chores
  • Updated container build process to copy source code earlier in the build stages for improved consistency across development and CI images. No impact on user-facing features or functionality.

[coderabbitai]

Walkthrough

The Dockerfiles for three different environments were updated to change when and where the source code is copied into the container during the build process. The COPY . /workspace instruction was moved from later development stages to earlier stages in the build, ensuring the source code is available sooner in the build pipeline.

Changes

Files	Change Summary
container/Dockerfile.sglang, container/Dockerfile.vllm	Moved COPY . /workspace from the end of the dev stage to the ci_minimum stage.
container/Dockerfile.tensorrt_llm	Added COPY . /workspace in the dev stage after copying workspace and Cargo cache, before build.

Poem

In Dockerfiles, the copy hops anew,
Source code leaps in earlier, not just a few.
From ci_minimum to dev, the files now appear,
Making sure every build is crystal clear.
Rabbits rejoice—less redundancy, more cheer!
🐇📦

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

container/Dockerfile.tensorrt_llm (1)

303-304: Combine COPY layers to improve caching and reduce image layers

You can merge the Cargo cache and workspace copies into a single Docker layer to reduce build time and image size. For example:

-COPY --from=wheel_builder $CARGO_HOME $CARGO_HOME
-COPY . /workspace
+COPY --from=wheel_builder $CARGO_HOME $CARGO_HOME \
+     . /workspace

Also consider adding a .dockerignore to exclude unnecessary files from the build context.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6336143 and 145c3c8.

📒 Files selected for processing (3)

• container/Dockerfile.sglang (1 hunks)
• container/Dockerfile.tensorrt_llm (1 hunks)
• container/Dockerfile.vllm (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Build and Test - vllm

🔇 Additional comments (2)

container/Dockerfile.sglang (1)

328-329: Source code now copied in ci_minimum stage

Moving COPY . /workspace into the ci_minimum stage ensures the source is available early and avoids redundant copies later in the dev stage. This aligns with the PR objective and maintains consistency across Dockerfiles.

container/Dockerfile.vllm (1)

406-407: Relocated workspace copy to ci_minimum stage

The COPY . /workspace moved to the ci_minimum stage properly makes the full source available before building C bindings and removes duplication from the dev stage.

[saturley-hall]

Looks like a copy-paste error from PR 1177