Skip to content

Conversation

@rmccorm4
Copy link
Contributor

@rmccorm4 rmccorm4 commented May 30, 2025

Overview:

  • This PR in TRTLLM made a breaking change renaming config field enable_overlap_scheduler to disable_overlap_scheduler and enabling overlap scheduler by default
    • Since our TRTLLM build process for external users is to build wheel from source - update the TRTLLM_COMMIT in build.sh to one that includes this disable_overlap_scheduler (and matches current CI commit)
    • For users installing pip wheel from pypi, they'll need to make sure the version they install includes this change trtllm change, which it should naturally include over the next few weeks of trtllm pip wheel releases.
    • For users with an existing older trtllm pip install, they can refer to an older stable release branch of dynamo before this change, ex: 0.3.0 or 0.2.1
  • Move free_gpu_mem_fraction under kv_cache_config section in all configs as it's strictly enforced now

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

Summary by CodeRabbit

  • Chores
    • Updated configuration files to replace the deprecated overlap scheduler setting with the new field, reflecting recent changes in the underlying backend.
    • Added explanatory comments to clarify the new default behavior and field name changes.
    • Updated internal build script to use the latest commit for dependency builds.
  • Style
    • Added missing trailing newlines to scripts for improved formatting.

rmccorm4 added 2 commits May 30, 2025 15:15
…er change for users building wheel from source with script directly
@rmccorm4 rmccorm4 requested a review from richardhuo-nv May 30, 2025 22:25
@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 30, 2025

Walkthrough

The updates standardize configuration files by replacing the deprecated enable_overlap_scheduler key with the new disable_overlap_scheduler key, inverting its logic as needed. Comments are added to clarify the change and reference the related commit. Additionally, the TensorRT-LLM build script is updated to use a newer commit hash and includes a trailing newline.

Changes

File(s) Change Summary
container/build.sh Updated TensorRT-LLM commit hash and added trailing newline.
examples/tensorrt_llm/configs/deepseek_r1/agg_llm_api_config.yaml Removed enable_overlap_scheduler; added comment about default behavior and key renaming.
examples/tensorrt_llm/configs/llm_api_config.yaml
examples/tensorrt_llm/configs/llm_api_config_router.yaml
examples/tensorrt_llm/configs/llm_api_config_disagg_router.yaml
Removed enable_overlap_scheduler; added explanatory comment referencing commit; no other changes.
examples/tensorrt_llm/configs/deepseek_r1/disagg_llm_api_config.yaml Replaced enable_overlap_scheduler with disable_overlap_scheduler (inverted logic); added clarifying comments.
examples/tensorrt_llm/configs/llmapi_disagg_configs/single_node_config.yaml
examples/tensorrt_llm/configs/llmapi_disagg_router_configs/single_node_config.yaml
Replaced enable_overlap_scheduler with disable_overlap_scheduler (inverted logic) for context and generation servers; added comments.

Poem

🐇
Out with the old, in with the new,
Scheduler keys have changed their hue!
“Enable” is gone, “disable” is here,
With comments to make the changes clear.
A fresh commit for wheels to spin,
Let the TensorRT magic begin!
🛠️✨


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between de2ef79 and 2efa136.

📒 Files selected for processing (2)
  • examples/tensorrt_llm/configs/deepseek_r1/disagg_llm_api_config.yaml (2 hunks)
  • examples/tensorrt_llm/configs/llm_api_config_disagg_router.yaml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • examples/tensorrt_llm/configs/deepseek_r1/disagg_llm_api_config.yaml
  • examples/tensorrt_llm/configs/llm_api_config_disagg_router.yaml
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Build and Test - vllm

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

…ction, set cuda graph to true for consistency in disagg router example
@rmccorm4 rmccorm4 enabled auto-merge (squash) May 31, 2025 02:05
@rmccorm4 rmccorm4 merged commit 859944f into main May 31, 2025
12 checks passed
@rmccorm4 rmccorm4 deleted the rmccormick/trtllm/disable_overlap_scheduler branch May 31, 2025 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants