Skip to content

fix: make imagePullSecrets optional when installing dynamo cloud #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julienmancuso merged 3 commits into from
Jun 2, 2025
Merged

fix: make imagePullSecrets optional when installing dynamo cloud #1324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84c27ea
fix: make imagePullSecrets optional when installing dynamo cloud
julienmancuso Jun 2, 2025
acbc39f
fix: make imagePullSecrets optional when installing dynamo cloud
julienmancuso Jun 2, 2025
70b4fca
Merge branch 'main' into jsm/dep-120
julienmancuso Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion deploy/cloud/helm/platform/components/api-store/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,4 +112,3 @@ spec:
tolerations:
{{- toYaml . | nindent 8 }}
{{- end }}
imagePullSecrets: {{ .Values.imagePullSecrets | default list | toJson }}
6 changes: 2 additions & 4 deletions deploy/cloud/helm/platform/components/api-store/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,8 @@ image:
# Overrides the image tag whose default is the chart appVersion.
tag: ""

# This is for the secretes for pulling an image from a private repository more information can be found here: https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/
imagePullSecrets:
- name: nvcrimagepullsecret
- name: docker-imagepullsecret
# This is for the secrets for pulling an image from a private repository more information can be found here: https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/
#imagePullSecrets: []
# This is to override the chart name.
nameOverride: ""
fullnameOverride: ""
Expand Down
5 changes: 4 additions & 1 deletion deploy/cloud/helm/platform/components/operator/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@ spec:
annotations:
kubectl.kubernetes.io/default-container: manager
spec:
{{- with .Values.imagePullSecrets }}
imagePullSecrets:
{{- toYaml . | nindent 8 }}
{{- end }}
containers:
- args: {{- toYaml .Values.controllerManager.kubeRbacProxy.args | nindent
8 }}
Expand Down Expand Up @@ -120,7 +124,6 @@ spec:
10 }}
securityContext: {{- toYaml .Values.controllerManager.manager.containerSecurityContext
| nindent 10 }}
imagePullSecrets: {{ .Values.imagePullSecrets | default list | toJson }}
securityContext:
runAsNonRoot: true
serviceAccountName: {{ include "dynamo-operator.fullname" . }}-controller-manager
Expand Down
2 changes: 1 addition & 1 deletion deploy/cloud/helm/platform/components/operator/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ dynamo:
cacheRepo: ''
snapshotMode: '' # options: full, redo, time

imagePullSecrets: []
#imagePullSecrets: []
kubernetesClusterDomain: cluster.local
metricsService:
ports:
Expand Down
7 changes: 0 additions & 7 deletions deploy/cloud/helm/platform/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,9 @@
# limitations under the License.
# Used to generate top-level secrets (overridden by custom-values.yaml)

imagePullSecrets:

# Subcharts
dynamo-operator:
enabled: true
imagePullSecrets:
- name: gitlab-imagepull
- name: nvcrimagepullsecret
- name: docker-imagepullsecret
natsAddr: ""
etcdAddr: ""
namespaceRestriction:
Expand Down Expand Up @@ -79,7 +73,6 @@ dynamo-api-store:
repository: ""
tag: "latest"
pullPolicy: IfNotPresent
imagePullSecrets:
ingress:
enabled: false
className: nginx
Expand Down
Loading