-
Notifications
You must be signed in to change notification settings - Fork 762
docs: Add note about ignore_eos for MTP #1475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe README for the TensorRT-LLM DeepSeek R1 examples was updated to clarify Multi-Token Prediction (MTP) usage, improve formatting, correct latency notes, and add a warning about the Changes
Sequence Diagram(s)No sequence diagram generated as the changes are documentation-only. Possibly related PRs
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
examples/tensorrt_llm/README.md (4)
132-136: Inconsistent config path formatting
The aggregated MTP example omits the leading./in the path (-f configs/...), whereas all other examples use-f ./configs/.... Align this for consistency.
140-141: Consider reformatting theignore_eosguidance
This bullet is quite dense. You might split it into two bullets or convert it into an admonition/note block to improve scannability.
237-239: Inconsistent config path formatting in multi-node section
Similar to the aggregated example, the multi-node MTP path is written as-f configs/.... Use-f ./configs/...here as well to match the rest of the docs.
273-274: Duplicateignore_eosnote
The same guidance aboutignore_eosappears twice. Consider referencing the original note or consolidating to avoid redundancy.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
examples/tensorrt_llm/README.md(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Mirror Repository to GitLab
- GitHub Check: Build and Test - vllm
Overview:
Adds note to docs about not using
ignore_eoswith MTP for realistic acceptance rates.Summary by CodeRabbit
ignore_eosparameter when using MTP to prevent unwanted outputs.