refactor: remove old examples with old UX #1899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alec-flowers
requested review from
a team,
GuanLuo,
PeaBrane,
biswapanda,
grahamking,
hhzhang16,
ishandhanani,
julienmancuso,
kkranen,
mohammedabdulwahhab,
nnshah1,
piotrm-nvidia,
ptarasiewiczNV,
rmccorm4,
tanmayv25,
tedzhouhk and
whoisj
as code owners
Contributor
WalkthroughThis change removes all source code, configuration files, and documentation related to the "hello_world", "llm_hello_world", and "multinode_example" examples, as well as their subcomponents and pipelines, from the repository. Additionally, it updates the README files for deprecated LLM-related examples to include explicit deprecation notices and removal timelines. Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
examples/vllm_v0_deprecated/README.md (1)
18-21: Use the same admonition style as the rest of the README for consistencyLater in the document, deprecation / warning messages use the
> [!NOTE]&> [!WARNING]call-out blocks. Re-formatting the new deprecation banner to that style keeps the file visually consistent and easier to scan.-# VLLM_0 example is deprecated -# Please move to the new vllm folder -# We will not be maintaining this example and will remove it by 0.4.0 +> [!WARNING] +> The `vllm_v0` example is **deprecated** and will be removed in **0.4.0**. +> Please migrate to the up-to-date examples in `examples/vllm`.examples/llm_deprecated/README.md (1)
18-21: Convert the deprecation banner to an admonition & avoid multiple top-level H1 headersThree consecutive
#headings introduce duplicate H1s and push the existing document title (line 22) down the hierarchy.
Switching to a single admonition preserves heading structure, provides better visual emphasis, and lets you hyperlink the new location.-# llm example is deprecated -# Please move to the new vllm folder -# We will not be maintaining this example and will remove it by 0.4.0 +> [!WARNING] +> **Deprecated** – This folder will be removed in `v0.4.0`. +> Please migrate to [`examples/vllm`](../vllm/); no further updates will be made here.Also ensure any hard-coded paths later in the doc (
cd $DYNAMO_HOME/examples/llm) are updated or annotated as legacy to avoid confusing users once the folder is renamed/removed.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (5)
examples/hello_world/multinode_example/_img/1workerready.pngis excluded by!**/*.pngexamples/hello_world/multinode_example/_img/2workerready.pngis excluded by!**/*.pngexamples/hello_world/multinode_example/_img/waiting1worker.pngis excluded by!**/*.pngexamples/llm_deprecated/benchmarks/example_plots/single_node_pareto_plot.pngis excluded by!**/*.pngexamples/llm_deprecated/benchmarks/example_plots/two_node_pareto_plot.pngis excluded by!**/*.png
📒 Files selected for processing (25)
examples/hello_world/README.md(0 hunks)examples/hello_world/config.yaml(0 hunks)examples/hello_world/deploy/hello_world.yaml(0 hunks)examples/hello_world/disagg_skeleton/README.md(0 hunks)examples/hello_world/disagg_skeleton/components/frontend.py(0 hunks)examples/hello_world/disagg_skeleton/components/graph.py(0 hunks)examples/hello_world/disagg_skeleton/components/kv_router.py(0 hunks)examples/hello_world/disagg_skeleton/components/prefill_worker.py(0 hunks)examples/hello_world/disagg_skeleton/components/processor.py(0 hunks)examples/hello_world/disagg_skeleton/components/utils.py(0 hunks)examples/hello_world/disagg_skeleton/components/worker.py(0 hunks)examples/hello_world/hello_world.py(0 hunks)examples/hello_world/multinode_example/README.md(0 hunks)examples/hello_world/multinode_example/components/frontend.py(0 hunks)examples/hello_world/multinode_example/components/graph.py(0 hunks)examples/hello_world/multinode_example/components/processor.py(0 hunks)examples/hello_world/multinode_example/components/utils.py(0 hunks)examples/hello_world/multinode_example/components/worker.py(0 hunks)examples/hello_world/multinode_example/configs/multi_worker.yaml(0 hunks)examples/hello_world/multinode_example/configs/one_worker.yaml(0 hunks)examples/llm/components/__init__.py(0 hunks)examples/llm_deprecated/README.md(1 hunks)examples/llm_hello_world/llm_hello_world.py(0 hunks)examples/llm_hello_world/llm_types.py(0 hunks)examples/vllm_v0_deprecated/README.md(2 hunks)
💤 Files with no reviewable changes (23)
- examples/hello_world/README.md
- examples/hello_world/multinode_example/configs/multi_worker.yaml
- examples/hello_world/multinode_example/components/graph.py
- examples/llm/components/init.py
- examples/hello_world/multinode_example/configs/one_worker.yaml
- examples/hello_world/disagg_skeleton/components/graph.py
- examples/hello_world/config.yaml
- examples/llm_hello_world/llm_types.py
- examples/hello_world/deploy/hello_world.yaml
- examples/hello_world/multinode_example/components/frontend.py
- examples/hello_world/multinode_example/components/worker.py
- examples/hello_world/disagg_skeleton/components/frontend.py
- examples/hello_world/disagg_skeleton/components/kv_router.py
- examples/hello_world/multinode_example/components/processor.py
- examples/hello_world/disagg_skeleton/components/worker.py
- examples/hello_world/disagg_skeleton/components/prefill_worker.py
- examples/hello_world/disagg_skeleton/README.md
- examples/hello_world/multinode_example/README.md
- examples/hello_world/disagg_skeleton/components/utils.py
- examples/hello_world/disagg_skeleton/components/processor.py
- examples/hello_world/hello_world.py
- examples/llm_hello_world/llm_hello_world.py
- examples/hello_world/multinode_example/components/utils.py
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: PeaBrane
PR: ai-dynamo/dynamo#1409
File: examples/router_standalone/worker.py:171-186
Timestamp: 2025-06-08T08:30:45.126Z
Learning: Example code in the `examples/` directory may intentionally use hard-coded values or simplified implementations that wouldn't be appropriate for production code, but are acceptable for demonstration and testing purposes.
Learnt from: biswapanda
PR: ai-dynamo/dynamo#1412
File: lib/bindings/python/src/dynamo/runtime/logging.py:100-100
Timestamp: 2025-06-06T21:48:35.214Z
Learning: In the Dynamo codebase, BentoML has been completely removed from all executable code, with only documentation and attribution references remaining. The error_loggers configuration in lib/bindings/python/src/dynamo/runtime/logging.py should not include "bentoml" since those modules no longer exist.
examples/llm_deprecated/README.md (2)
Learnt from: PeaBrane
PR: ai-dynamo/dynamo#1409
File: examples/router_standalone/worker.py:171-186
Timestamp: 2025-06-08T08:30:45.126Z
Learning: Example code in the `examples/` directory may intentionally use hard-coded values or simplified implementations that wouldn't be appropriate for production code, but are acceptable for demonstration and testing purposes.
Learnt from: krishung5
PR: ai-dynamo/dynamo#1388
File: examples/multimodal/utils/model.py:47-53
Timestamp: 2025-06-09T17:52:06.761Z
Learning: The current get_vision_embeddings_size() function in examples/multimodal/utils/model.py uses a hardcoded fallback of 4096 for hidden_size, which assumes all VLMs follow the LLaVA architecture pattern. This is problematic because different VLMs like Qwen2-VL, MiniCPM-V, and others have different hidden dimensions, making the fallback unreliable and potentially causing tensor shape mismatches.
examples/vllm_v0_deprecated/README.md (1)
Learnt from: PeaBrane
PR: ai-dynamo/dynamo#1409
File: examples/router_standalone/worker.py:171-186
Timestamp: 2025-06-08T08:30:45.126Z
Learning: Example code in the `examples/` directory may intentionally use hard-coded values or simplified implementations that wouldn't be appropriate for production code, but are acceptable for demonstration and testing purposes.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build and Test - vllm
PeaBrane
approved these changes
Jul 11, 2025
alec-flowers
force-pushed
the
aflowers/deprecate-old-ux
branch
from
c83860e to
74390b8
Compare
alec-flowers
force-pushed
the
aflowers/deprecate-old-ux
branch
from
74390b8 to
a8a2ac9
Compare
alec-flowers
requested review from
jthomson04,
paulhendricks and
tmonty12
as code owners
alec-flowers
changed the title
alec-flowers
changed the title
grahamking
approved these changes
Jul 14, 2025
nnshah1
reviewed
Jul 14, 2025
nnshah1
reviewed
Jul 14, 2025
nnshah1
approved these changes
Jul 14, 2025
Contributor
nnshah1
left a comment
nnshah1
left a comment
There was a problem hiding this comment.
Follow up action items:
- add e2e basic tests (bash based)
- add new k8s yamls
Contributor
|
CI e2e tests (Compound AI k8s tests and Fault-Tolerence) will break and we might not catch regressions.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Remove old examples that use the old UX. Also clear the integration tests for the old vLLM. Will include new tests shortly for the new vLLM folder.
Summary by CodeRabbit
Removals
Documentation