feat: add Kubernetes service account configuration for SLA profiling jobs #1975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhzhang16
requested review from
a team,
GuanLuo,
PeaBrane,
alec-flowers,
biswapanda,
grahamking,
ishandhanani,
jthomson04,
kkranen,
nnshah1,
paulhendricks,
piotrm-nvidia,
ptarasiewiczNV,
rmccorm4,
ryanolson,
tanmayv25,
tedzhouhk,
tmonty12 and
whoisj
as code owners
mohammedabdulwahhab
requested changes
Jul 16, 2025
hhzhang16
force-pushed
the
hannahz/dep-239-explore-use-of-service-accounts-in-k8s
branch
from
01b6df3 to
1193c4e
Compare
julienmancuso
approved these changes
Jul 16, 2025
mohammedabdulwahhab
approved these changes
Jul 17, 2025
hhzhang16
deleted the
hannahz/dep-239-explore-use-of-service-accounts-in-k8s
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
This MR builds on the vLLM v1 profiling work to add proper Kubernetes service account configuration for running SLA profiling jobs in a cluster environment.
Details:
dynamo_deployment.pyto support service account-based authentication and authorizationWhere should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)