Skip to content

fix: handle groveTerminationDelay and auto-detect grove installation #2190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julienmancuso merged 8 commits into from
Aug 1, 2025
Merged

fix: handle groveTerminationDelay and auto-detect grove installation #2190

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3ab1f82
fix: handle groveTerminationDelay and auto-detect grove installation
julienmancuso Jul 30, 2025
9b37b4a
fix: handle groveTerminationDelay and auto-detect grove installation
julienmancuso Jul 30, 2025
8d56d20
fix: handle groveTerminationDelay and auto-detect grove installation
julienmancuso Jul 30, 2025
1c08997
fix: handle groveTerminationDelay and auto-detect grove installation
julienmancuso Jul 30, 2025
8f72269
fix: handle groveTerminationDelay and auto-detect grove installation
julienmancuso Jul 30, 2025
a9eb58c
fix: handle groveTerminationDelay and auto-detect grove installation
julienmancuso Jul 30, 2025
01e3e20
fix: handle groveTerminationDelay and auto-detect grove installation
julienmancuso Jul 31, 2025
ffad8e6
fix: handle groveTerminationDelay and auto-detect grove installation
julienmancuso Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: handle groveTerminationDelay and auto-detect grove installation
  • Loading branch information
@julienmancuso
julienmancuso committed Jul 31, 2025
commit 01e3e205e8cc9748da422c3f116115ef32cd27d4
4 changes: 3 additions & 1 deletion deploy/cloud/operator/internal/dynamo/graph.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,9 @@ func GenerateGrovePodGangSet(ctx context.Context, dynamoDeployment *v1alpha1.Dyn
gangSet.Name = dynamoDeployment.Name
gangSet.Namespace = dynamoDeployment.Namespace
gangSet.Spec.Replicas = 1
gangSet.Spec.Template.TerminationDelay = &metav1.Duration{Duration: controllerConfig.Grove.TerminationDelay}
if controllerConfig.Grove.TerminationDelay > 0 {
gangSet.Spec.Template.TerminationDelay = &metav1.Duration{Duration: controllerConfig.Grove.TerminationDelay}
}
for componentName, component := range dynamoDeployment.Spec.Services {
container := corev1.Container{
Name: "main",
Expand Down
Loading