Skip to content

fix: support config without resource limit for profile sla script #2201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tedzhouhk merged 2 commits into from
Jul 31, 2025
Merged

fix: support config without resource limit for profile sla script #2201

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
356ff95
fix: support config without limit
tedzhouhk Jul 30, 2025
8a1e163
pc
tedzhouhk Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
pc
  • Loading branch information
@tedzhouhk
tedzhouhk committed Jul 30, 2025
commit 8a1e1631cff150fa28197c5fc222fa3f4942b3f6
9 changes: 6 additions & 3 deletions benchmarks/profiler/utils/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,12 @@ def set_config_tp_size(cls, config: dict, tp_size: int):
config["spec"]["services"][
WORKER_COMPONENT_NAMES["vllm"].decode_worker_k8s_name
]["resources"]["requests"]["gpu"] = str(tp_size)
if "limits" in config["spec"]["services"][
WORKER_COMPONENT_NAMES["vllm"].decode_worker_k8s_name
]["resources"]:
if (
"limits"
in config["spec"]["services"][
WORKER_COMPONENT_NAMES["vllm"].decode_worker_k8s_name
]["resources"]
):
config["spec"]["services"][
WORKER_COMPONENT_NAMES["vllm"].decode_worker_k8s_name
]["resources"]["limits"]["gpu"] = str(tp_size)
Expand Down
Loading