-
Notifications
You must be signed in to change notification settings - Fork 750
fix: Address QA issues + product feedback #2202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
992adfb
fix: add better port logic (#2175) (#2192)
alec-flowers 9a93f11
chore: fix install (#2191)
ishandhanani 5d4b3ca
changes to address QA issues
athreesh aa42f9d
trigger PR refresh
athreesh 760d406
Merge main into anish/fix
athreesh dbb1eaf
Revert Dockerfile.sglang changes to match main
athreesh c8bd069
same dockerfile as one in main
athreesh d292048
added containers & helm charts
athreesh fcc114d
fix merge conflict + edit exampels readme
athreesh 52774a0
Resolve merge conflict in examples/README.md - keep Framework Support…
athreesh 3e7186d
adding a readme for benchmarks folder
athreesh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,52 @@ | ||
| <!-- | ||
| SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| SPDX-License-Identifier: Apache-2.0 | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| --> | ||
|
|
||
| [../../examples/llm/benchmarks/README.md](../../examples/llm/benchmarks/README.md) | ||
| # LLM Benchmarking Tools | ||
|
|
||
| This directory contains tools for benchmarking LLM inference performance in Dynamo deployments. | ||
|
|
||
| ## Overview | ||
|
|
||
| The benchmarking suite includes: | ||
| - **`perf.sh`** - Automated performance benchmarking script using GenAI-Perf | ||
| - **`plot_pareto.py`** - Results analysis and Pareto efficiency visualization | ||
| - **`nginx.conf`** - Load balancer configuration for multi-backend setups | ||
|
|
||
| ## Key Parameters | ||
|
|
||
| | Parameter | Description | Default | | ||
| |-----------|-------------|---------| | ||
| | `--tensor-parallelism, --tp` | Tensor parallelism for aggregated mode | 0 | | ||
| | `--data-parallelism, --dp` | Data parallelism for aggregated mode | 0 | | ||
| | `--prefill-tp` | Prefill tensor parallelism for disaggregated mode | 0 | | ||
| | `--prefill-dp` | Prefill data parallelism for disaggregated mode | 0 | | ||
| | `--decode-tp` | Decode tensor parallelism for disaggregated mode | 0 | | ||
| | `--decode-dp` | Decode data parallelism for disaggregated mode | 0 | | ||
| | `--model` | HuggingFace model ID | `neuralmagic/DeepSeek-R1-Distill-Llama-70B-FP8-dynamic` | | ||
| | `--url` | Target inference endpoint | `http://localhost:8000` | | ||
| | `--concurrency` | Comma-separated concurrency levels | `1,2,4,8,16,32,64,128,256` | | ||
| | `--isl` | Input sequence length | 3000 | | ||
| | `--osl` | Output sequence length | 150 | | ||
| | `--mode` | Serving mode (`aggregated` or `disaggregated`) | `aggregated` | | ||
|
|
||
|
|
||
| ## Best Practices | ||
|
|
||
| 1. **Warm up services** before benchmarking to ensure stable performance | ||
| 2. **Match parallelism settings** to your actual deployment configuration | ||
| 3. **Run multiple benchmark iterations** for statistical confidence | ||
| 4. **Monitor resource utilization** during benchmarks to identify bottlenecks | ||
| 5. **Compare configurations** using Pareto plots to find optimal settings | ||
|
|
||
| ## Requirements | ||
|
|
||
| - GenAI-Perf tool installed and available in PATH | ||
| - Python 3.7+ with matplotlib, pandas, seaborn, numpy | ||
| - nginx (for load balancing scenarios) | ||
| - Access to target LLM inference service | ||
|
|
||
| ## Troubleshooting | ||
|
|
||
| - Ensure the target URL is accessible before running benchmarks | ||
| - Verify model names match those available in your deployment | ||
| - Check that parallelism settings align with your hardware configuration | ||
| - Monitor system resources to avoid resource contention during benchmarks | ||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still some EOF issue