Skip to content

Conversation

@biswapanda
Copy link
Contributor

@biswapanda biswapanda commented Jul 31, 2025

Overview:

  • add jq for frontend health probes (usage)

https://nvbugspro.nvidia.com/bug/5425651

closes:
nvbug: 5425651
linear ticket: DYN-792

Details:

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

Summary by CodeRabbit

  • Chores
    • Added the jq utility to runtime images across multiple containers to enhance endpoint polling and health check capabilities.
    • Updated documentation comments to indicate that both jq and curl are now installed for these purposes.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 31, 2025

Walkthrough

The Dockerfiles for four different container images were updated to install the jq utility alongside curl during the runtime image setup. Corresponding comments were also revised to indicate that both tools are used for polling endpoints and performing health checks. No other changes were made.

Changes

Cohort / File(s) Change Summary
Dockerfile jq & curl Installation
container/Dockerfile.sglang, container/Dockerfile.sglang-wideep, container/Dockerfile.tensorrt_llm, container/Dockerfile.vllm
Added jq to the list of installed packages alongside curl and updated comments to reflect both are used for polling endpoints and health checks. No other modifications.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇
With Dockerfiles neat and jq now in tow,
Alongside curl, we’re ready to go!
For health checks and polling, our scripts are complete—
These tiny tweaks make our containers more sweet.
Hop, hop, hooray, for tools at our feet!

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 57482dc and 532333b.

📒 Files selected for processing (4)
  • container/Dockerfile.sglang (1 hunks)
  • container/Dockerfile.sglang-wideep (1 hunks)
  • container/Dockerfile.tensorrt_llm (1 hunks)
  • container/Dockerfile.vllm (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
container/Dockerfile.vllm (1)

Learnt from: grahamking
PR: #1177
File: container/Dockerfile.vllm:102-105
Timestamp: 2025-05-28T22:54:46.875Z
Learning: In Dockerfiles, when appending to environment variables that may not exist in the base image, Docker validation will fail if you reference undefined variables with ${VARIABLE} syntax. In such cases, setting the environment variable directly (e.g., ENV CPATH=/usr/include) rather than appending is the appropriate approach.

🪛 GitHub Actions: NVIDIA Test Github Validation
container/Dockerfile.vllm

[error] 42-42: Docker build failed due to unauthorized access (401 Unauthorized) when pulling base image 'nvcr.io/nvidia/cuda-dl-base:25.01-cuda12.8-devel-ubuntu24.04'. Failed to resolve source metadata for the base image.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Mirror Repository to GitLab
🔇 Additional comments (4)
container/Dockerfile.vllm (1)

440-442: LGTM! Proper addition of jq for health checks.

The addition of the jq package alongside curl is appropriate for the stated purpose of health checks and endpoint polling. The comment accurately reflects the packages being installed and their intended use.

container/Dockerfile.tensorrt_llm (1)

383-385: LGTM! Consistent addition of jq across Dockerfiles.

The addition of jq alongside curl for health checks and endpoint polling is consistent with the other Dockerfiles in this PR. The comment clearly explains the purpose of both packages.

container/Dockerfile.sglang-wideep (1)

155-158: LGTM! Appropriate addition of jq for perf_analyzer dependencies.

The addition of jq and curl packages is properly documented for their use in polling endpoints and health checks. This aligns with the PR objective and is consistent with the changes in other Dockerfiles.

container/Dockerfile.sglang (1)

432-434: LGTM! Consistent implementation of jq installation.

The addition of jq alongside curl is consistent with the other Dockerfiles and properly documented. The packages are correctly positioned within the existing package installation block for the runtime image.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dmitry-tokarev-nv dmitry-tokarev-nv merged commit 62c7898 into main Jul 31, 2025
9 of 10 checks passed
@dmitry-tokarev-nv dmitry-tokarev-nv deleted the bis/add-curl-jq branch July 31, 2025 01:16
biswapanda added a commit that referenced this pull request Jul 31, 2025
dmitry-tokarev-nv added a commit that referenced this pull request Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants