-
Notifications
You must be signed in to change notification settings - Fork 749
fix: add curl and jq for health checks #2203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe Dockerfiles for four different container images were updated to install the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (4)
🧰 Additional context used🧠 Learnings (1)container/Dockerfile.vllm (1)Learnt from: grahamking 🪛 GitHub Actions: NVIDIA Test Github Validationcontainer/Dockerfile.vllm[error] 42-42: Docker build failed due to unauthorized access (401 Unauthorized) when pulling base image 'nvcr.io/nvidia/cuda-dl-base:25.01-cuda12.8-devel-ubuntu24.04'. Failed to resolve source metadata for the base image. ⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Co-authored-by: Dmitry Tokarev <[email protected]>
Co-authored-by: Dmitry Tokarev <[email protected]>
Overview:
jqfor frontend health probes (usage)https://nvbugspro.nvidia.com/bug/5425651
closes:
nvbug: 5425651
linear ticket: DYN-792
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit
jqutility to runtime images across multiple containers to enhance endpoint polling and health check capabilities.jqandcurlare now installed for these purposes.