Skip to content

Conversation

@biswapanda
Copy link
Contributor

@biswapanda biswapanda commented Aug 3, 2025

Overview:

Cherrypick from main: #2257

Overview:

  • update dynamo inference gateway doc to point at examples
  • rebased on latest main to get changes from docs: Dyn 591 #2247
  • add instruction to deploy using custom images

closes:
linear: DEP-297
nvbug

Details:

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 3, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@biswapanda biswapanda force-pushed the bis/dep-297-cp-release branch from 03c690d to 9f8798b Compare August 4, 2025 04:13
@biswapanda biswapanda requested review from a team, nealvaidya and whoisj as code owners August 4, 2025 04:13
@pull-request-size pull-request-size bot added size/XL and removed size/L labels Aug 4, 2025
@biswapanda biswapanda force-pushed the bis/dep-297-cp-release branch from 9f8798b to c1336da Compare August 4, 2025 04:13
@biswapanda biswapanda changed the title doc: add instruction to deploy model with inference gateway doc: add instruction to deploy model with inference gateway #2257 Aug 4, 2025
Copy link
Contributor

@atchernych atchernych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like the new Troubleshooting section :)

Copy link
Contributor

@mohammedabdulwahhab mohammedabdulwahhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but shouldn't the cherry-pick PR wait for the merge to main first?

@dmitry-tokarev-nv dmitry-tokarev-nv changed the title doc: add instruction to deploy model with inference gateway #2257 docs: add instruction to deploy model with inference gateway #2257 Aug 5, 2025
@github-actions github-actions bot added the docs label Aug 5, 2025
Copy link
Contributor

@dmitry-tokarev-nv dmitry-tokarev-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@biswapanda there are conflicts - can you resolve?

@biswapanda
Copy link
Contributor Author

Approving, but shouldn't the cherry-pick PR wait for the merge to main first?

This is isolated doc only change and QA was able to verify this in parallel until code owners approve the PR

@biswapanda
Copy link
Contributor Author

@biswapanda there are conflicts - can you resolve?

Thanks @dmitry-tokarev-nv. resolved the issue now.

@biswapanda biswapanda enabled auto-merge (squash) August 5, 2025 05:44
@biswapanda biswapanda self-assigned this Aug 5, 2025
@biswapanda
Copy link
Contributor Author

Fix has been verified by QA https://nvbugspro.nvidia.com/bug/5427727

@dmitry-tokarev-nv dmitry-tokarev-nv merged commit 27c8a97 into release/0.4.0 Aug 5, 2025
11 of 13 checks passed
@dmitry-tokarev-nv dmitry-tokarev-nv deleted the bis/dep-297-cp-release branch August 5, 2025 06:25
tzulingk pushed a commit that referenced this pull request Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants