Skip to content

fix: trtllm container - ENV var used before declaration #2277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmitry-tokarev-nv merged 6 commits into from
Aug 5, 2025
Merged

fix: trtllm container - ENV var used before declaration #2277

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b301c6d
trtllm container - Moved WORKDIR /workspace all the way down
dmitry-tokarev-nv Aug 4, 2025
f30d35f
Added ls commands to list what is in the /workspace
dmitry-tokarev-nv Aug 4, 2025
9c2ff14
TRTLLM Dockerfile - Moved NIXL ENV vars to the top of runtime
dmitry-tokarev-nv Aug 4, 2025
20fe615
TRTLLM dockerfile - fixed relative path
dmitry-tokarev-nv Aug 4, 2025
6c84a6e
cleanup
dmitry-tokarev-nv Aug 5, 2025
9351fde
Merge branch 'release/0.4.0' into dtokarev-trtllm-move-workspace-down
dmitry-tokarev-nv Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cleanup
  • Loading branch information
@dmitry-tokarev-nv
dmitry-tokarev-nv committed Aug 5, 2025
commit 6c84a6e51cceff76a411ad4d023c58d6054eae12
11 changes: 4 additions & 7 deletions container/Dockerfile.tensorrt_llm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,16 +313,14 @@ RUN uv build --wheel --out-dir /workspace/dist && \
FROM build AS dev

WORKDIR /workspace
RUN ls -lah /workspace

COPY --from=wheel_builder /workspace /workspace
RUN ls -lah /workspace
# Copy Cargo cache to avoid re-downloading dependencies
COPY --from=wheel_builder $CARGO_HOME $CARGO_HOME

# Copy rest of the code
RUN ls -lah /workspace
COPY . /workspace
RUN ls -lah /workspace

# Package the bindings
RUN mkdir -p /opt/dynamo/bindings/wheels && \
mkdir /opt/dynamo/bindings/lib && \
Expand Down Expand Up @@ -375,6 +373,8 @@ CMD []

FROM ${RUNTIME_IMAGE}:${RUNTIME_IMAGE_TAG} AS runtime

WORKDIR /workspace

ARG ARCH_ALT

ENV DYNAMO_HOME=/workspace
Expand Down Expand Up @@ -528,8 +528,5 @@ RUN --mount=type=bind,source=./container/launch_message.txt,target=/workspace/la
sed '/^#\s/d' /workspace/launch_message.txt > ~/.launch_screen && \
echo "cat ~/.launch_screen" >> ~/.bashrc

# potentially having /workspace at the top grabs some old cache files from ci/cd
WORKDIR /workspace

ENTRYPOINT ["/opt/nvidia/nvidia_entrypoint.sh"]
CMD []
Loading