feat: add recorder to KVBM Connector #2289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziqifan617
requested review from
a team,
GuanLuo,
PeaBrane,
alec-flowers,
biswapanda,
grahamking,
ishandhanani,
jthomson04,
kkranen,
nnshah1,
paulhendricks,
piotrm-nvidia,
ptarasiewiczNV,
rmccorm4,
ryanolson,
tanmayv25,
tedzhouhk and
tmonty12
as code owners
ryanolson
reviewed
Aug 6, 2025
lib/bindings/python/rust/llm/block_manager/vllm/connector/leader/recorder.rs
Outdated
Show resolved
Hide resolved
ryanolson
reviewed
Aug 6, 2025
lib/bindings/python/rust/llm/block_manager/vllm/connector/leader/recorder.rs
Outdated
Show resolved
Hide resolved
ryanolson
requested changes
Aug 6, 2025
Contributor
ryanolson
left a comment
ryanolson
left a comment
There was a problem hiding this comment.
just the one change to UnboundedSender to eliminate the need to do the block_on bits everywhere
ziqifan617
force-pushed
the
ziqi/connector-recorder
branch
from
2992f55 to
b5fab23
Compare
ryanolson
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)